[jboss-jira] [JBoss JIRA] (WFLY-11135) Object, instead of a simple boolean should be returned by stop operation on mod_cluster

[Radoslav Husar (Jira)]

    [ https://issues.jboss.org/browse/WFLY-11135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644865#comment-13644865 ] 

Radoslav Husar edited comment on WFLY-11135 at 10/8/18 6:35 PM:
----------------------------------------------------------------

Actually, the legacy operation (with a fix for WFLY-11117) outputs the legacy format as expected:

{code}
[standalone at localhost:9990 /] /subsystem=modcluster:stop()
{
    "outcome" => "success",
    "response-headers" => {"warnings" => [{
        "warning" => "WFLYCTL0449: Operation stop against the resource at address /subsystem=modcluster is deprecated, and it might be removed in future version. See the the output of the read-operation-description operation to learn more about the deprecation.",
        "level" => "WARNING",
        "operation" => {
            "address" => [("subsystem" => "modcluster")],
            "operation" => "stop"
        }
    }]},
    "result" => {"session-draining-complete" => true}
}
{code}

The new format is intentional, the extra wrapping  "result" => \{"session-draining-complete" => ... is not necessary and more inline with other operation results.



was (Author: rhusar):
Actually, the legacy operation (with a fix for WFLY-11117) outputs the legacy format as expected:

{code}
[standalone at localhost:9990 /] /subsystem=modcluster:stop()
{
    "outcome" => "success",
    "response-headers" => {"warnings" => [{
        "warning" => "WFLYCTL0449: Operation stop against the resource at address /subsystem=modcluster is deprecated, and it might be removed in future version. See the the output of the read-operation-description operation to learn more about the deprecation.",
        "level" => "WARNING",
        "operation" => {
            "address" => [("subsystem" => "modcluster")],
            "operation" => "stop"
        }
    }]},
    "result" => {"session-draining-complete" => true}
}
{code}

The new format is intentional, the wrapping  "result" => {"session-draining-complete" => true} is not necessary.


> Object, instead of a simple boolean should be returned by stop operation on mod_cluster
> ---------------------------------------------------------------------------------------
>
>                 Key: WFLY-11135
>                 URL: https://issues.jboss.org/browse/WFLY-11135
>             Project: WildFly
>          Issue Type: Bug
>          Components: mod_cluster
>    Affects Versions: 14.0.0.Final
>            Reporter: Jan Kašík
>            Assignee: Radoslav Husar
>            Priority: Minor
>
> When calling {{stop}} operation, object should be returned:
> {code}
> [standalone at 127.0.0.1:9990 /] /subsystem=modcluster/proxy=default:stop()
> {
>     "outcome" => "success",
>     "result" => {"session-draining-complete" => true}
> }
> {code}
> Instead, just boolean is returned:
> {code}
> [standalone at 127.0.0.1:9990 /] /subsystem=modcluster/proxy=default:stop()
> {
>     "outcome" => "success",
>     "result" => true
> }
> {code}



--
This message was sent by Atlassian Jira
(v7.12.1#712002)