[jboss-jira] [JBoss JIRA] (DROOLS-3116) [DMN Designer] Literal Expression is not saved

[Matteo Mortari (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646970#comment-13646970 ] 

Matteo Mortari edited comment on DROOLS-3116 at 10/11/18 4:16 PM:
------------------------------------------------------------------

I don't recall by heart the dialogue on this topic,
but I am pretty sure this requirement: https://issues.jboss.org/browse/DROOLS-2217?focusedCommentId=13522142&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13522142
which was reflected as an assert statement: https://github.com/kiegroup/kie-wb-common/commit/904ce4a76efc676c65ce513ceafdf0e28c67051f#diff-e60839568850ea8b772f18a29a2dc30aR936
in the code, was as the request which came from the previous JIRA.

I understand you want now instead, that if a user chosen a Literal Expression, but missed to fill the expression, it will be unmarshalled again as an Literal expression (with null text).

I will change the code following the new requirement as part of this JIRA then.


was (Author: tari_manga):
I don't recall by heart the dialogue on this topic,
but I am pretty sure this requirement: https://issues.jboss.org/browse/DROOLS-2217?focusedCommentId=13522142&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13522142
which was reflected as an assert statement: https://github.com/kiegroup/kie-wb-common/commit/904ce4a76efc676c65ce513ceafdf0e28c67051f#diff-e60839568850ea8b772f18a29a2dc30aR936
in the code, was as the request which came from the previous JIRA.

I understand you want now instead, that if a user chosen a Literal Expression, but missed to fill the expression, it will be unmarshalled again as an Literal expression with an empty (NON-null) text string --please bear in mind when coming from XML I cannot omit the <text> element as it would generate an invalid XML, so it will have an <text> element with a string of 0character, which will reflect as an empty String of the LiteralExpression.

I will change the code following the new requirement as part of this JIRA then.

> [DMN Designer] Literal Expression is not saved
> ----------------------------------------------
>
>                 Key: DROOLS-3116
>                 URL: https://issues.jboss.org/browse/DROOLS-3116
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>    Affects Versions: 7.13.0.Final
>            Reporter: Jozef Marko
>            Assignee: Matteo Mortari
>            Priority: Blocker
>              Labels: drools-tools
>
> Literal Expression of decision node is not saved.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)