[jboss-jira] [JBoss JIRA] (WFCORE-4147) (WF15) Wrong JAVA_OPTS propagation, wrong PowerShell GC logging

[Marek Kopecký (Jira)]

    [ https://issues.jboss.org/browse/WFCORE-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647114#comment-13647114 ] 

Marek Kopecký commented on WFCORE-4147:
---------------------------------------

[~jamezp] Thank you for your investigation. So ... I guess that one (first or second) of these two options is correct, right? (the other one is wrong)

* sh and bat scripts shouldn't call "-version" command with JDK11, because it is redundant and it creates redundant and confusing (confusing for WF users) "gc.log.0" file
* ps1 script should call "-version" command with JDK11 (and probably also with JDK8), because this check is necessary. Sh, bat and ps1 scripts needs to remove redundant and confusing (confusing for WF users) "gc.log.0" file right after "-version" command on JDK11 (not necessary on JDK8)

> (WF15) Wrong JAVA_OPTS propagation, wrong PowerShell GC logging
> ---------------------------------------------------------------
>
>                 Key: WFCORE-4147
>                 URL: https://issues.jboss.org/browse/WFCORE-4147
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Scripts
>            Reporter: Marek Kopecký
>            Assignee: Radovan Stancel
>            Priority: Blocker
>              Labels: Java11
>
> Wrong JAVA_OPTS propagation, wrong PowerShell GC logging
> Merging of [PR3496|https://github.com/wildfly/wildfly-core/pull/3496] introduces:
> * new blocker regression
> ** Wrong JAVA_OPTS propagation on JDK8
> *** Default JAVA_OPTS, like max heap size (xmx), xms, etc. are not propagated to JVM on bat scripts
> *** set "GC_LOG=true"
> *** standalone.bat
> *** ->
> *** {noformat}===============================================================================
>   JBoss Bootstrap Environment
>   JBOSS_HOME: "C:\Users\Administrator\playground\wfly.30.gc\wildfly"
>   JAVA: "C:\Program Files\Java\jdk1.8.0_121\bin\java"
>   JAVA_OPTS: ""-Dprogram.name=standalone.bat -Xms64M -Xmx512M -XX:MetaspaceSize=96M -XX:MaxMetaspaceSize=256m -Djava.net.preferIPv4Stack=true -Djboss.modules.system.pkgs=org.jboss.byteman" -Xloggc:"C:\Users\Administrator\playground\wfly.30.gc\wildfly\standalone\log\gc.log" -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=5 -XX:GCLogFileSize=3M -XX:-TraceClassUnloading "
> ==============================================================================={noformat}
> *** it looks like some quotation bug
> *** according to the jconsole - max heap size (Xmx) is not set correctly (~1.8GB), according to the cli - program.name is not set correctly (program.name = "standalone.bat -Xms64M -Xmx512M -XX:MetaspaceSize=96M -XX:MaxMetaspaceSize=256m -Djava.net.preferIPv4Stack=true -Djboss.modules.system.pkgs=org.jboss.byteman")
> * new blocker bug
> ** wrong PowerShell GC logging
> *** "standalone.bat + jdk11 + gc enabled" creates:
> **** standalone\log\gc.log
> **** standalone\log\gc.log.0
> *** "standalone.ps1 + jdk11 + gc enabled" creates:
> **** * standalone\log\gc.log
> Target release of this jira should be WF15



--
This message was sent by Atlassian Jira
(v7.12.1#712002)