[jboss-jira] [JBoss JIRA] (WFLY-11181) XAResourceRecoveryServiceConfigurator adds a TX service dependency for non-transactional caches

[Brian Stansberry (Jira)]

     [ https://issues.jboss.org/browse/WFLY-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Stansberry updated WFLY-11181:
------------------------------------
    Git Pull Request: https://github.com/wildfly/wildfly/pull/11745


> XAResourceRecoveryServiceConfigurator adds a TX service dependency for non-transactional caches
> -----------------------------------------------------------------------------------------------
>
>                 Key: WFLY-11181
>                 URL: https://issues.jboss.org/browse/WFLY-11181
>             Project: WildFly
>          Issue Type: Bug
>          Components: Clustering
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>            Priority: Major
>
> I _think_ this is wrong...
> XAResourceRecoveryServiceConfigurator is installed for all caches, not just ones with the  ones with the component=transaction child resource.  That's basically ok because its accept and get methods only do things if this.cache.get().getCacheConfiguration().transaction().recovery().enabled(). But, the problem is the service dependency on the XAResourceRecoveryRegistry service the transaction subsystem provides is always added, so even if is wouldn't be used the dependency is added.
> I think WFLY-11167 will make it possible to correct this by 1) doing capability checking before adding the service dependency and 2) adding a capability requirement in TransactionResourceDefinition.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)