[jboss-jira] [JBoss JIRA] (DROOLS-3184) [DMN Designer] Edge source and target WayPoints are same

[Michael Anstis (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652937#comment-13652937 ] 

Michael Anstis commented on DROOLS-3184:
----------------------------------------

Bit more information.

When the {{MagnetConnector}} is created from the toolbox it is connected to the right side of the source shape and left side of the target shape. Whereas when the connector is created _manually_ by clicking on the connector icon in the toolbox and dragging to a target shape the {{MagnetConnection}} is set to connect to the middle/centre of the shapes.

The {{MagnetConnection}} has a property to ascertain if it is connected to the middle/left or right however it is [marked|https://github.com/kiegroup/kie-wb-common/blob/master/kie-wb-common-stunner/kie-wb-common-stunner-core/kie-wb-common-stunner-commons/kie-wb-common-stunner-core-common/src/main/java/org/kie/workbench/common/stunner/core/graph/content/view/DiscreteConnection.java#L26] as transient and hence gets thrown away when marshalled to the server for marshalling to DMN XML. So we cannot rely on this field :-( 

We need to stick with:
- If the "connection source/target location is {{null}}" assume it's the centre of the shape.
- If it is non-{{null}} it is relative to the source/target shape location.


> [DMN Designer] Edge source and target WayPoints are same
> --------------------------------------------------------
>
>                 Key: DROOLS-3184
>                 URL: https://issues.jboss.org/browse/DROOLS-3184
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>    Affects Versions: 7.14.0.Final
>            Reporter: Jozef Marko
>            Assignee: Michael Anstis
>            Priority: Major
>              Labels: drools-tools
>         Attachments: Screenshot from 2018-10-25 12-12-20.png, a1.dmn, image (2).png
>
>
> The source of DMN model has same waypoint for edge source and target. If you open the attached  [^a1.dmn] model, there will be:
> {code:xml}
> <dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
>         <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
>         <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
>       </dmndi:DMNEdge>
> {code}
> However in our designer the edge has different waypoints:
>  !Screenshot from 2018-10-25 12-12-20.png|thumbnail! 
> In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
>  !image (2).png|thumbnail! 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)