[jboss-jira] [JBoss JIRA] (DROOLS-2919) [DMN Designer] Data-types: Clean-up

[Jozef Marko (JIRA)]

     [ https://issues.jboss.org/browse/DROOLS-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jozef Marko updated DROOLS-2919:
--------------------------------
    Description: 
During review of the PRs adding support to the different grids, both [~jomarko] and [~karreiro] found some re-occurring issues that need addressing. Rather than fix at the point of discovery, i.e. when my colleagues review the PR, I prefer to circle back and fix all together once the queue of pending PRs are merged.

Current action items:

* (/) https://github.com/kiegroup/kie-wb-common/pull/2055#discussion_r212084447

* (/) https://github.com/kiegroup/kie-wb-common/pull/2041#discussion_r212250221

* (/) https://github.com/kiegroup/kie-wb-common/pull/2075/files#diff-5192d74da9265134c5792e63362222faR202 and https://github.com/kiegroup/kie-wb-common/pull/2075/files#diff-5192d74da9265134c5792e63362222faR206 - check for other occurrences too. If we pass a parameter as to whether to update "Stunner" title or not we can remove these methods accessing the super implementation.

* (/) Review whether _legacy_ {{BaseExpressionGrid.HeaderTextAreaFactory}} related methods are required when all grids support "in place" editing of name and data-type. Removing if possible.

h2. Acceptance test
Data type can be changed for
- All supported node types
- All supported expression types

  was:
During review of the PRs adding support to the different grids, both [~jomarko] and [~karreiro] found some re-occurring issues that need addressing. Rather than fix at the point of discovery, i.e. when my colleagues review the PR, I prefer to circle back and fix all together once the queue of pending PRs are merged.

Current action items:

* (/) https://github.com/kiegroup/kie-wb-common/pull/2055#discussion_r212084447

* (/) https://github.com/kiegroup/kie-wb-common/pull/2041#discussion_r212250221

* (/) https://github.com/kiegroup/kie-wb-common/pull/2075/files#diff-5192d74da9265134c5792e63362222faR202 and https://github.com/kiegroup/kie-wb-common/pull/2075/files#diff-5192d74da9265134c5792e63362222faR206 - check for other occurrences too. If we pass a parameter as to whether to update "Stunner" title or not we can remove these methods accessing the super implementation.

* (/) Review whether _legacy_ {{BaseExpressionGrid.HeaderTextAreaFactory}} related methods are required when all grids support "in place" editing of name and data-type. Removing if possible.

h2. Acceptance test
Data type can be changed for
- All node supported node types
- All supported expression types



> [DMN Designer] Data-types: Clean-up
> -----------------------------------
>
>                 Key: DROOLS-2919
>                 URL: https://issues.jboss.org/browse/DROOLS-2919
>             Project: Drools
>          Issue Type: Enhancement
>          Components: DMN Editor
>    Affects Versions: 7.10.0.Final
>            Reporter: Michael Anstis
>            Assignee: Michael Anstis
>              Labels: drools-tools
>
> During review of the PRs adding support to the different grids, both [~jomarko] and [~karreiro] found some re-occurring issues that need addressing. Rather than fix at the point of discovery, i.e. when my colleagues review the PR, I prefer to circle back and fix all together once the queue of pending PRs are merged.
> Current action items:
> * (/) https://github.com/kiegroup/kie-wb-common/pull/2055#discussion_r212084447
> * (/) https://github.com/kiegroup/kie-wb-common/pull/2041#discussion_r212250221
> * (/) https://github.com/kiegroup/kie-wb-common/pull/2075/files#diff-5192d74da9265134c5792e63362222faR202 and https://github.com/kiegroup/kie-wb-common/pull/2075/files#diff-5192d74da9265134c5792e63362222faR206 - check for other occurrences too. If we pass a parameter as to whether to update "Stunner" title or not we can remove these methods accessing the super implementation.
> * (/) Review whether _legacy_ {{BaseExpressionGrid.HeaderTextAreaFactory}} related methods are required when all grids support "in place" editing of name and data-type. Removing if possible.
> h2. Acceptance test
> Data type can be changed for
> - All supported node types
> - All supported expression types



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)