[jboss-jira] [JBoss JIRA] (WFCORE-4099) Prevent failures due to MSC-240 in 'critical' code

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631332#comment-13631332 ] 

Brian Stansberry edited comment on WFCORE-4099 at 9/10/18 2:14 PM:
-------------------------------------------------------------------

The attached ServiceBuilderUsage.txt report is incorrect re the 'org.jboss.as.server.deployment' package.  The 'register' method marked CRITICAL there is only called from a DeploymentUnitPhaseServiceImpl, which controls the type of SB that is passed in.  -So at most those lines would be MINOR_PUBLIC.- These aren't even MINOR_PUBLIC, as while the DeploymentUnitPhaseDependency interface shouldn't be public (not necessary) none of the actual use of it is outside private code in the same package.


was (Author: brian.stansberry):
The attached ServiceBuilderUsage.txt report is incorrect re the 'org.jboss.as.server.deployment' package.  The 'register' method marked CRITICAL there is only called from a DeploymentUnitPhaseServiceImpl, which controls the type of SB that is passed in.  So at most those lines would be MINOR_PUBLIC.

> Prevent failures due to MSC-240 in 'critical' code
> --------------------------------------------------
>
>                 Key: WFCORE-4099
>                 URL: https://issues.jboss.org/browse/WFCORE-4099
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Management, Server
>    Affects Versions: 6.0.2.Final
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>            Priority: Blocker
>         Attachments: ServiceBuilderusage.txt
>
>
> As discussed in MSC-240, different impls of the MSC ServiceBuilder interface will support different subsets of the ServiceBuilder API, throwing UnsupportedOperationException if methods not in that subset are invoked.  This makes code that accepts an SB from unknown origins vulnerable to failure if the wrong type of SB is passed in.
> WFCORE-4090 is an example of such a failure.
> I've done an analysis WildFly and WildFly Core use of ServiceBuilder looking for problematic cases.  I will attach the analysis.  This JIRA is to fix the items in WF Core that are annotated with the CRITICAL notation.
> A possible fix for this is simply incorporating an MSC release that has MSC-240 adequately resolved. (Note that adequate doesn't mean completely fixed; simply preventing problems in the methods annotated as CRITICAL is sufficient.)  Barring that a fix would be to avoid or deal with the UOE.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)