[jboss-jira] [JBoss JIRA] (JGRP-2294) ForkProtocolStack ignores UnknownForkHandler for message batches

[Dan Berindei (JIRA)]

     [ https://issues.jboss.org/browse/JGRP-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Berindei updated JGRP-2294:
-------------------------------
    Description: 
{{ForkProtocolStack.up(MessageBatch)}} discards messages if it doesn't the fork channel id isn't registered and they are part of a batch:

{code:java}
                log.debug("fork-channel for id=%s not found; discarding message", fork_channel_id);
{code}

-I believe the check should also be enhanced to invoke the {{UnknownForkHandler}} if the {{ForkChannel}} is registered but is not yet connected. Otherwise messages that arrive after the {{ForkChannel}} registers itself in the constructor and before our {{JGroupsTransport}} registers itself as an {{UpHandler}} with the {{ForkChannel}} will also be discarded.-

I misread the {{ForkChannel}} code, the registratioon in the {{ForkProtocolStack}} only happens in {{ForkChannel.connect()}}.


  was:
{{ForkProtocolStack.up(MessageBatch)}} discards messages if it doesn't the fork channel id isn't registered and they are part of a batch:

{code:java}
                log.debug("fork-channel for id=%s not found; discarding message", fork_channel_id);
{code}

~~I believe the check should also be enhanced to invoke the {{UnknownForkHandler}} if the {{ForkChannel}} is registered but is not yet connected. Otherwise messages that arrive after the {{ForkChannel}} registers itself in the constructor and before our {{JGroupsTransport}} registers itself as an {{UpHandler}} with the {{ForkChannel}} will also be discarded.~~

I misread the {{ForkChannel}} code, the registratioon in the {{ForkProtocolStack}} only happens in {{ForkChannel.connect()}}.




> ForkProtocolStack ignores UnknownForkHandler for message batches
> ----------------------------------------------------------------
>
>                 Key: JGRP-2294
>                 URL: https://issues.jboss.org/browse/JGRP-2294
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 4.0.13
>            Reporter: Dan Berindei
>            Assignee: Bela Ban
>
> {{ForkProtocolStack.up(MessageBatch)}} discards messages if it doesn't the fork channel id isn't registered and they are part of a batch:
> {code:java}
>                 log.debug("fork-channel for id=%s not found; discarding message", fork_channel_id);
> {code}
> -I believe the check should also be enhanced to invoke the {{UnknownForkHandler}} if the {{ForkChannel}} is registered but is not yet connected. Otherwise messages that arrive after the {{ForkChannel}} registers itself in the constructor and before our {{JGroupsTransport}} registers itself as an {{UpHandler}} with the {{ForkChannel}} will also be discarded.-
> I misread the {{ForkChannel}} code, the registratioon in the {{ForkProtocolStack}} only happens in {{ForkChannel.connect()}}.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)