[jboss-jira] [JBoss JIRA] (DROOLS-3037) [DMN Designer] Added item definition has not icon of structure

[Guilherme Carreiro (JIRA)]

    [ https://issues.jboss.org/browse/DROOLS-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638827#comment-13638827 ] 

Guilherme Carreiro edited comment on DROOLS-3037 at 9/26/18 9:14 AM:
---------------------------------------------------------------------

[~jomarko],

I don't think that the absence of the the icons in some Data Types is a bug. The initial prototypes show that only Data Types with children has an icon, see:
 !initial-prototypes.png|thumbnail! 

However, the UX team worked in a enhancement for this topic, and now we have two kinds of icons in the dialog (one for simple Data Types and other for structure Data Types):
https://issues.jboss.org/browse/DROOLS-2876?focusedCommentId=13634494&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13634494

We don't have a JIRA for applying the changed suggested by the DROOLS-2876, so we can keep this one. But, maybe we could change it from "Bug" to "Task" ;-)

Thanks.


was (Author: karreiro):
[~jomarko],

I don't think that the absence of the the icons in some Data Types is a bug. The initial prototypes explicitly show that only Data Types with children has an icon, see:
 !initial-prototypes.png|thumbnail! 

However, the UX team worked in a enhancement for this topic, and now we have two kinds of icons in the dialog (one for simple data types and other for structure data types):
https://issues.jboss.org/browse/DROOLS-2876?focusedCommentId=13634494&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13634494

We don't have a JIRA for applying the changed suggested by the DROOLS-2876, so we can keep this one. But, maybe we could change it from "Bug" to "Task" ;-)

Thanks.

> [DMN Designer] Added item definition has not icon of structure
> --------------------------------------------------------------
>
>                 Key: DROOLS-3037
>                 URL: https://issues.jboss.org/browse/DROOLS-3037
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>    Affects Versions: 7.12.0.Final
>            Reporter: Jozef Marko
>            Assignee: Guilherme Carreiro
>              Labels: drools-tools
>         Attachments: Screenshot from 2018-09-26 12-33-28.png, initial-prototypes.png
>
>
> If user add custom item definition and define it as structure, the item definition misses the structure icon set the attached picture. There is new custom structure item definition *a* without icon. Compare it with other structure item definitions.
> h2. Acceptance test
> - Check added item definition has icon when it is top level
> - Check added item definition has icon when used in nested level
> - Check item definition has not structure icon when changed from structure to something else
> - Check item definition has structure icon when changed from something else to structure
> - Check item definition has structure icon if item definition is recursive



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)