[jboss-jira] [JBoss JIRA] (DROOLS-3727) [DMN Designer] Quick Silver: Minimal standalone preparation

[Michael Anstis (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716132#comment-13716132 ] 

Michael Anstis commented on DROOLS-3727:
----------------------------------------

Hi [~roger600], I'll include [~jomarko] in this reply as he's been asking similar questions.

Firstly a summary: 

My branch tidied up the dependencies for DMN without making too many changes elsewhere. There is more work to be done (primarily trying to reduce the dependencies needed for DMN's use of client-side only dynamic forms. At the moment way too many additional dependencies are needed by Forms - mainly to support the server side creation - and these drag in dependencies with AppFormer's plugins and Layout editor!) My branch also endeavours to make using the same _core_ editor in both 7.x and 8.x (Submarine) so we don't have to worry too much about maintaining two code bases. This works quite well at the moment however I need to complete more changes for the Submarine wrapper as things like {{Path}} and {{PlaceManager}} are no longer available. 

Regarding _running_ the DMN editor in Submarine. I made the DMN editor _fit_ the requirements of Submarine ({{setContent(String)}} and {{String getContent()}} methods that accept and return a DMN XML String that converted to/from {{Diagram}} with a RPC). As far as Submarine is concerned all interactions with an Editor are via these two client-side methods. I don't run DMN in VSCode or Che. This is work that [~porcelli] did based on my branch. He made some revisions but these have been merged and (as of today) my local changes make the DMN editor _look_ almost 100% like [~porcelli] revisions.

We are coming to a point where we need to probably start running DMN in VSCode/Che ourselves and that will require deciding where to put Submarine work I've done.. at the moment it is in {{kiegroup/kie-wb-common}} however this uses the old AppFormer repository that lacks the work [~porcelli] has done in a new repository to support Submarine. WHEN [~porcelli] work is moved to the kie Submarine repositories then I think, once my Submarine specific work in {{kiegroup/kie-wb-common}} can move there too and we can begin to run in VSCode. [~porcelli] thoughts?
{quote}
How are we both going to work on this...
{quote}
Well, my branch is "work in progress" at the moment. I hope to complete the work today and submit a PR for {{kiegroup/kie-wb-common at master}} this week (the sooner the better). Then you can make BPMN work "as good as" the DMN standalone in {{kiegroup/kie-wb-comon}}. This would make it simple to then run from VSCode once the necessary repository is setup and any outstanding move/integration work completes.
{quote}
I see all editors being refactored, also the DMN webapp too
{quote}
Yes, my work covering all _Stunner_ editors (not all!) is to support using the same _core_ editor codebase ongoing in both 7.x and 8.x (Submarine). I think I've covered what I'd see as the next steps in my narrative above.. i.e. once my outstanding changes are complete and moved to {{kiegroup/kie-wb-common}} you can make similar changes to BPMN's standalone webapp (following those made to DMN) to make a VSCode compatible webapp.
{quote}
Also I cannot find yet where this branch is integrated with the {{EditorPresenter}}
{quote}
Me neither! This was [~porcelli] work and he needs to communicate where/how we run in VSCode. This ties in with other comments I've made here.

> [DMN Designer] Quick Silver: Minimal standalone preparation
> -----------------------------------------------------------
>
>                 Key: DROOLS-3727
>                 URL: https://issues.jboss.org/browse/DROOLS-3727
>             Project: Drools
>          Issue Type: Task
>          Components: DMN Editor
>            Reporter: Michael Anstis
>            Assignee: Michael Anstis
>            Priority: Critical
>              Labels: Stunner, drools-tools, submarine
>             Fix For: 8.0.0.Final
>
>
> Prepare a minimal DMN Designer standalone WAR that only supports _standalone_ mode.
> No Home Page, no Library, No preferences, no other editors.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)