[jboss-jira] [JBoss JIRA] (DROOLS-3702) [Stunner] Arrows are incorrectly positioned when save-open diagram

[Michael Anstis (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717111#comment-13717111 ] 

Michael Anstis commented on DROOLS-3702:
----------------------------------------

Hi [~roger600],

I agree that when nodes are added in the UI they appear to be using AUTO (is this new?!)

I also had a quick look at our marshaller and you are correct "...I understand that DMN marshallers are not supporting this _auto-magnet_ strategy...". It definitely appears to be setting magnets using {{MagnetConnection.Builder.at(..)}} which is {{FIXED}} where as I assume we should be using something more like {{MagnetConnection.Builder.atCenter(..)}} if we want them centred. I tried and tested this and is makes re-opening diagrams much nicer!

In reality however, if we want to preserve the original magnets set in the UI when adding Nodes, we need to preserve Stunner's magnet strategy. Failing to do so means we can only intelligently decide between {{CENTRE}} (the connection end-point is equal to the centre of the {{View}}) or {{AUTO}} (we would not be able to differentiate between {{AUTO}} and {{FIXED}} just by inspecting the geometry).

So, [~tirelli] and/or [~tari_manga] what do you prefer?
# Store additional extensions in the DMN file for Stunner's magnet strategy
# Default to either CENTRE or AUTO depending on a quick check to ascertain if the connection end-point is at the centre of the node.

We'd need to use the above default when opening diagrams not authored with our tooling as they'd lack the meta-data.

> [Stunner] Arrows are incorrectly positioned when save-open diagram
> ------------------------------------------------------------------
>
>                 Key: DROOLS-3702
>                 URL: https://issues.jboss.org/browse/DROOLS-3702
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>            Reporter: Daniel José dos Santos
>            Assignee: Michael Anstis
>            Priority: Major
>              Labels: Stunner
>         Attachments: auto-magnets.gif, fixed-magnets.gif, process-designer-connectors-magnets-issues.png, weird_arrow.gif
>
>
> 1. Add a `Decision Node`
> 2. Add a `Input Data Node` bellow `Decision Node`
> 3. Connect `Input Data Node` to `Decision Node`
> 4. Save
> 5. Close
> 6. Open againThe arrow from `Input Data Node` to `Decision Node` will be at right of the `Decision Node` and if you move the `Input Data Node`, the arrow is not repositioned.
> I noticed this in DMN Showcase and in drools-wb.
> And if you add a new `Decision Node` and a new `Input Data Node`, without save and close, it behaves as expected.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)