[jboss-jira] [JBoss JIRA] (DROOLS-3702) [Stunner] Arrows are incorrectly positioned when save-open diagram

[Michael Anstis (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717133#comment-13717133 ] 

Michael Anstis commented on DROOLS-3702:
----------------------------------------

[~tari_manga] I agree.. 

Other tools keep the {{FIXED}} (x, y) and clip the connector when it intercepts the node's boundary (whereas Stunner overlaps it, giving the reported issue).

Ideally Stunner could also do the same for {{FIXED}} magnets however for the purpose of this JIRA I propose we default to AUTO when re-opening.

However considering that to be a not insignificant effort I found simply changing {{DMNMarshaller.setConnectionMagnets(..)}} to call {{setAuto(true)}} on the new connection magnets seems to give an improvement on the reported issue (and makes reopening a diagram authored in our editor behave the same as it did when first authored). See [here|https://github.com/kiegroup/kie-wb-common/blob/master/kie-wb-common-dmn/kie-wb-common-dmn-backend/src/main/java/org/kie/workbench/common/dmn/backend/DMNMarshaller.java#L512] and [here|https://github.com/kiegroup/kie-wb-common/blob/master/kie-wb-common-dmn/kie-wb-common-dmn-backend/src/main/java/org/kie/workbench/common/dmn/backend/DMNMarshaller.java#L520]. 

> [Stunner] Arrows are incorrectly positioned when save-open diagram
> ------------------------------------------------------------------
>
>                 Key: DROOLS-3702
>                 URL: https://issues.jboss.org/browse/DROOLS-3702
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>            Reporter: Daniel José dos Santos
>            Assignee: Michael Anstis
>            Priority: Major
>              Labels: Stunner
>         Attachments: auto-magnets.gif, fixed-magnets.gif, process-designer-connectors-magnets-issues.png, weird_arrow.gif
>
>
> 1. Add a `Decision Node`
> 2. Add a `Input Data Node` bellow `Decision Node`
> 3. Connect `Input Data Node` to `Decision Node`
> 4. Save
> 5. Close
> 6. Open againThe arrow from `Input Data Node` to `Decision Node` will be at right of the `Decision Node` and if you move the `Input Data Node`, the arrow is not repositioned.
> I noticed this in DMN Showcase and in drools-wb.
> And if you add a new `Decision Node` and a new `Input Data Node`, without save and close, it behaves as expected.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)