[jboss-jira] [JBoss JIRA] (WFLY-11991) Add Hibernate ORM transformer option to transform any method parameter of type org.hibernate.engine.spi.SessionImplementor

[Scott Marlow (Jira)]

    [ https://issues.jboss.org/browse/WFLY-11991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722631#comment-13722631 ] 

Scott Marlow edited comment on WFLY-11991 at 4/15/19 3:31 PM:
--------------------------------------------------------------

Seems that the answer to the last question is that the [https://github.com/wildfly/wildfly/blob/master/jpa/hibernate-transformer/src/main/java/org/jboss/as/hibernate/Hibernate51CompatibilityTransformer.java#L271] check for Ljava/lang/Object is not going to match.  I will create a new jira issue for not handling Ljava/lang/Object parameter matching correctly.



was (Author: smarlow):
Seems that the answer to the last question is that the [https://github.com/wildfly/wildfly/blob/master/jpa/hibernate-transformer/src/main/java/org/jboss/as/hibernate/Hibernate51CompatibilityTransformer.java#L271] check for Ljava/lang/Object is not going to match.

So we can either replace the check for Ljava/lang/Object, to instead match any object type (via custom code) or simplify this code by depending on the Hibernate51TransformSessImplMtds checking by default (which may mean we need less code).  

Next need to understand if having Hibernate51TransformSessImplMtds enabled by default, could cause any problems with application code that has a Lorg/hibernate/engine/spi/SessionImplementor parameter that shouldn't be replaced with Lorg/hibernate/engine/spi/SharedSessionContractImplementor.

> Add Hibernate ORM transformer option to transform any method parameter of type org.hibernate.engine.spi.SessionImplementor
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WFLY-11991
>                 URL: https://issues.jboss.org/browse/WFLY-11991
>             Project: WildFly
>          Issue Type: Enhancement
>          Components: JPA / Hibernate
>            Reporter: Scott Marlow
>            Assignee: Scott Marlow
>            Priority: Major
>         Attachments: afterchange.zip, beforechange.zip
>
>
> Test case (change) is [https://github.com/simkam/wildfly/compare/hibernate_transformer].  The idea is to transform any class method parameter of type org.hibernate.engine.spi.SessionImplementor, in user application for any class found that isn't in the org.hibernate package.
> [https://github.com/scottmarlow/wildfly/tree/WFLY-11991] also includes the test case (change), as well as in progress code changes.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)