[jboss-jira] [JBoss JIRA] (WFLY-12380) Fix org.wildfly.clustering.service.ServiceSupplier usage

Paul Ferraro (Jira) issues at jboss.org
Thu Aug 15 12:19:00 EDT 2019


Paul Ferraro created WFLY-12380:
-----------------------------------

             Summary: Fix org.wildfly.clustering.service.ServiceSupplier usage
                 Key: WFLY-12380
                 URL: https://issues.jboss.org/browse/WFLY-12380
             Project: WildFly
          Issue Type: Bug
          Components: Clustering
            Reporter: Paul Ferraro
            Assignee: Paul Ferraro


When PassiveServiceSupplier is used to obtain the value of a service for use by metrics, it is generally safe to construct it using OperationContext.getServiceRegistry(false), as it does not affect the MSC state of the target service.

ActiveServiceSupplier, on the other hand, must always be constructed with OperationContext.getServiceRegistry(true).  It is meant to obtain the value of an ACTIVEly installed service, thus its get() should never return null.  I'd like to convert as many uses of ActiveServiceSupplier to PassiveServiceSupplier as possible.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)


More information about the jboss-jira mailing list