[jboss-jira] [JBoss JIRA] (WFLY-12427) Missing io.smallrye.health dependency on org.jboss.logging

[Brian Stansberry (Jira)]

    [ https://issues.jboss.org/browse/WFLY-12427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774994#comment-13774994 ] 

Brian Stansberry edited comment on WFLY-12427 at 8/24/19 12:44 PM:
-------------------------------------------------------------------

As I commented on the https://github.com/wildfly/wildfly/pull/12527
 PR I tried for this (and ultimately closed):

Adding the org.jbss.logging dependency causes all sorts of failures due to:

{code}
org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy jaxws-authentication-ejb.jar: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-1" => {"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.\"jaxws-authentication-ejb.jar\".WeldStartService" => "Failed to start service
    Caused by: org.jboss.weld.exceptions.DeploymentException: WELD-001408: Unsatisfied dependencies for type String with qualifiers @Default
  at injection point [BackedAnnotatedField] @Inject io.smallrye.health.SmallRyeHealthReporter.uncheckedExceptionDataStyle
  at io.smallrye.health.SmallRyeHealthReporter.uncheckedExceptionDataStyle(SmallRyeHealthReporter.java:0)
"}}}}
org.jboss.arquillian.container.spi.client.container.DeploymentException: 
Cannot deploy jaxws-authentication-ejb.jar: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-1" => {"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.\"jaxws-authentication-ejb.jar\".WeldStartService" => "Failed to start service
    Caused by: org.jboss.weld.exceptions.DeploymentException: WELD-001408: Unsatisfied dependencies for type String with qualifiers @Default
  at injection point [BackedAnnotatedField] @Inject io.smallrye.health.SmallRyeHealthReporter.uncheckedExceptionDataStyle
  at io.smallrye.health.SmallRyeHealthReporter.uncheckedExceptionDataStyle(SmallRyeHealthReporter.java:0)
"}}}}
{code}

It seems that resolving the INFO logged problem in the JIRA produces bigger problems, so perhaps not having the org.jboss.logging dependency was deliberate.

In any case I will downgrade this to Minor as the logging is at INFO, it's just a bit scary looking.


was (Author: brian.stansberry):
As I commented on the PR I tried for this (and ultimately closed):

Adding the org.jbss.logging dependency causes all sorts of failures due to:

{code}
org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy jaxws-authentication-ejb.jar: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-1" => {"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.\"jaxws-authentication-ejb.jar\".WeldStartService" => "Failed to start service
    Caused by: org.jboss.weld.exceptions.DeploymentException: WELD-001408: Unsatisfied dependencies for type String with qualifiers @Default
  at injection point [BackedAnnotatedField] @Inject io.smallrye.health.SmallRyeHealthReporter.uncheckedExceptionDataStyle
  at io.smallrye.health.SmallRyeHealthReporter.uncheckedExceptionDataStyle(SmallRyeHealthReporter.java:0)
"}}}}
org.jboss.arquillian.container.spi.client.container.DeploymentException: 
Cannot deploy jaxws-authentication-ejb.jar: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-1" => {"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.\"jaxws-authentication-ejb.jar\".WeldStartService" => "Failed to start service
    Caused by: org.jboss.weld.exceptions.DeploymentException: WELD-001408: Unsatisfied dependencies for type String with qualifiers @Default
  at injection point [BackedAnnotatedField] @Inject io.smallrye.health.SmallRyeHealthReporter.uncheckedExceptionDataStyle
  at io.smallrye.health.SmallRyeHealthReporter.uncheckedExceptionDataStyle(SmallRyeHealthReporter.java:0)
"}}}}
{code}

It seems that resolving the INFO logged problem in the JIRA produces bigger problems, so perhaps not having the org.jboss.logging dependency was deliberate.

In any case I will downgrade this to Minor as the logging is at INFO, it's just a bit scary looking.

> Missing io.smallrye.health dependency on org.jboss.logging
> ----------------------------------------------------------
>
>                 Key: WFLY-12427
>                 URL: https://issues.jboss.org/browse/WFLY-12427
>             Project: WildFly
>          Issue Type: Bug
>          Components: MP Health
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>            Priority: Minor
>
> I happened to notice this in a server log of a CI job:
> {code}
> 16:03:53,351 INFO  [org.jboss.weld.Bootstrap] (Weld Thread Pool -- 2) WELD-000119: Not generating any bean definitions from io.smallrye.health.SmallRyeHealthReporter because of underlying class loading error: Type org.jboss.logging.Logger from [Module "io.smallrye.health" version 1.0.2 from local module loader @4909b8da (finder: local module finder @3a03464 (roots: C:\buildAgent\work\37b47ae8b9c60325\full\testsuite\integration\smoke\target\wildfly\modules,C:\buildAgent\work\37b47ae8b9c60325\full\testsuite\integration\smoke\target\wildfly\modules\system\layers\base,C:\buildAgent\work\37b47ae8b9c60325\full\testsuite\integration\smoke\target\modules))] not found.  If this is unexpected, enable DEBUG logging to see the full error.
> {code}
> The io.smallrye:smallrye-health-2.0:1.0.2 pom shows a dependency on JBoss Logging but the module.xml for its module does not.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)