[jboss-jira] [JBoss JIRA] (WFLY-12854) Consider to allow non-resuable metrics of the same name in subdeployments

[Ivan Straka (Jira)]

     [ https://issues.redhat.com/browse/WFLY-12854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Straka updated WFLY-12854:
-------------------------------
    Description: 
If two method annotated to use MP Metrics have same name. In case of _Counters_ (example):
* They are reusable there is actually one MP metric and both method invocation are counted to a single metric.
* They are non-reusable:
** They are in the same deployment - ERROR is logged and metrics are not registerd
** They are in different deployments
*** (X) MP Config _mp.metrics.appName_ is used thus metrics are registered under _configured_name;_app=the value_ thus they are registered under different name
*** MP Config _mp.metrics.appName_ is not used - ERROR is logged and metrics are not registerd

Now I'd like to talk about the (X) option. This is valid for two scenarios:
* Multiple deployments
* Deployment with sub-deployments.

In  Multiple deployments I am able to to annotate two methods with non-reusable metric of the same name. I need to set MP Config _mp.metrics.appName_ property. Then I can select the metric using a tag.

However per https://github.com/smallrye/smallrye-metrics/issues/216 I am not able to do that in deployment with sub-deployments scenario.

This is inconsistent behavior and it would be good to have it implemented.

  was:
If two method annotated to use MP Metrics have same name. In case of _Counters_ (example):
* They are reusable there is actually one MP metric and both method invocation are counted to a single metric.
* They are non-reusable:
** They are in the same deployment - ERROR is logged and metrics are not registerd
** They are in different deployments
*** (X) MP Config _mp.metrics.appName_ is used thus metrics are registered under _configured_name;_app=the value_ thus they are registered under different name
*** MP Config _mp.metrics.appName_ is not used - ERROR is logged and metrics are not registerd

Now I'd like to talk about the (X) option. This is valid for two scenarios:
* Multiple deployments
* Deployment with sub-deployments.

In  Multiple deployments I am able to to annotate two methods with non-reusable metric of the same name. I need to set MP Config _mp.metrics.appName_ property. Then I can select the metric by a tag.

However per https://github.com/smallrye/smallrye-metrics/issues/216 I am not able to do that in deployment with sub-deployments scenario.

This is inconsistent behavior and it would be good to have it implemented.



> Consider to allow non-resuable metrics of the same name in subdeployments
> -------------------------------------------------------------------------
>
>                 Key: WFLY-12854
>                 URL: https://issues.redhat.com/browse/WFLY-12854
>             Project: WildFly
>          Issue Type: Feature Request
>          Components: MP Metrics
>            Reporter: Ivan Straka
>            Assignee: Jeff Mesnil
>            Priority: Major
>
> If two method annotated to use MP Metrics have same name. In case of _Counters_ (example):
> * They are reusable there is actually one MP metric and both method invocation are counted to a single metric.
> * They are non-reusable:
> ** They are in the same deployment - ERROR is logged and metrics are not registerd
> ** They are in different deployments
> *** (X) MP Config _mp.metrics.appName_ is used thus metrics are registered under _configured_name;_app=the value_ thus they are registered under different name
> *** MP Config _mp.metrics.appName_ is not used - ERROR is logged and metrics are not registerd
> Now I'd like to talk about the (X) option. This is valid for two scenarios:
> * Multiple deployments
> * Deployment with sub-deployments.
> In  Multiple deployments I am able to to annotate two methods with non-reusable metric of the same name. I need to set MP Config _mp.metrics.appName_ property. Then I can select the metric using a tag.
> However per https://github.com/smallrye/smallrye-metrics/issues/216 I am not able to do that in deployment with sub-deployments scenario.
> This is inconsistent behavior and it would be good to have it implemented.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)