[jboss-jira] [JBoss JIRA] (DROOLS-4845) Fix error-popover position on simulation/model grids

[Gabriele Cardosi (Jira)]

    [ https://issues.redhat.com/browse/DROOLS-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821589#comment-13821589 ] 

Gabriele Cardosi edited comment on DROOLS-4845 at 12/5/19 10:49 AM:
--------------------------------------------------------------------

[~yamer]

This is the snippet

{code:java}
/* It determines if the popover should be draw on the RIGHT or in the LEFT of the cell */
        if (xPosition + POPOVER_WIDTH > scenarioGrid.getLayer().getWidth()) {
            xPosition = (int) cellXYMiddleCoordinates.getX() - xMiddleWidth;
            position = PopoverView.Position.LEFT;
        }
{code}
Error could be related to
1) {code:java}scenarioGrid.getLayer().getWidth(){code} - maybe it is not the correct "container" to consider
2) not considering  {code:java}int scrollX = scenarioGridPanel.getScrollPanel().getElement().getScrollLeft();{code} in the `if` evaluation
3) both/any

 


was (Author: gabriolo):
[~yamer]

This is the snippet

{code:java}
/* It determines if the popover should be draw on the RIGHT or in the LEFT of the cell */
        if (xPosition + POPOVER_WIDTH > scenarioGrid.getLayer().getWidth()) {
            xPosition = (int) cellXYMiddleCoordinates.getX() - xMiddleWidth;
            position = PopoverView.Position.LEFT;
        }
{code}
Error could be related to
1) `scenarioGrid.getLayer().getWidth()` - maybe it is not the correct "container" to consider
2) not considering ` int scrollX = scenarioGridPanel.getScrollPanel().getElement().getScrollLeft();` in the `if` evaluation
3) both/any

 

> Fix error-popover position on simulation/model grids
> ----------------------------------------------------
>
>                 Key: DROOLS-4845
>                 URL: https://issues.redhat.com/browse/DROOLS-4845
>             Project: Drools
>          Issue Type: Bug
>          Components: Scenario Simulation and Testing
>            Reporter: Jozef Marko
>            Assignee: Yeser Amer
>            Priority: Major
>
> The issue was found during DROOLS-4767 review. There we fixed position of error popup to have ordering "RIGHT -> LEFT -> ABOVE". However this ordering doesn't work on the main Model tab if your resize the properties panel/docks at right site.
> For more details see the [github comment|https://github.com/kiegroup/drools-wb/pull/1271#pullrequestreview-327445489]. 
>  



--
This message was sent by Atlassian Jira
(v7.13.8#713008)