[jboss-jira] [JBoss JIRA] (DROOLS-4807) [DMN Designer] Do not group V&V messages by UUID

[Michael Anstis (Jira)]

     [ https://issues.redhat.com/browse/DROOLS-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Anstis updated DROOLS-4807:
-----------------------------------
    Description: 
The V&V results are grouped by UUID. See attached screen-shot.

These items are reported individually by {{kie-dmn-validation}} but grouped by {{org.kie.workbench.common.dmn.showcase.backend.validation.ValidationServiceImpl}} in the _standalone_ webapp however I fear Stunner's generic {{ValidationService}} does the same in Business Central and hence reporting DMN V&V per-line may be more troublesum.

See [here|https://github.com/kiegroup/kie-wb-common/blob/master/kie-wb-common-dmn/kie-wb-common-dmn-webapp-standalone/src/main/java/org/kie/workbench/common/dmn/showcase/backend/validation/ValidationServiceImpl.java#L56] that should more correctly be:-
{code}
    @Override
    public Collection<DiagramElementViolation<RuleViolation>> validate(Diagram diagram) {
        return domainViolations(diagram).stream()
                .filter(v -> Objects.nonNull(v.getUUID()))
                .filter(v -> !"null".equals(v.getUUID()))
                .map(v -> new ElementViolationImpl.Builder().setUuid(v.getUUID()).setDomainViolations(Collections.singletonList(v)).build())
                .collect(Collectors.toList());
    }
{code}

h3. Acceptance criteria
- Create a DMN file
- Add a Decision node with no content
- Validate it
- Each validation message should be a separate item in the Alert panel

  was:
The V&V results are grouped by UUID. See attached screen-shot.

These items are reported individually by {{kie-dmn-validation}} but grouped by {{org.kie.workbench.common.dmn.showcase.backend.validation.ValidationServiceImpl}} in the _standalone_ webapp however I fear Stunner's generic {{ValidationService}} does the same in Business Central and hence reporting DMN V&V per-line may be more troublesum.

See [here|https://github.com/kiegroup/kie-wb-common/blob/master/kie-wb-common-dmn/kie-wb-common-dmn-webapp-standalone/src/main/java/org/kie/workbench/common/dmn/showcase/backend/validation/ValidationServiceImpl.java#L56] that should more correctly be:-
{code}
    @Override
    public Collection<DiagramElementViolation<RuleViolation>> validate(Diagram diagram) {
        return domainViolations(diagram).stream()
                .filter(v -> Objects.nonNull(v.getUUID()))
                .filter(v -> !"null".equals(v.getUUID()))
                .map(v -> new ElementViolationImpl.Builder().setUuid(v.getUUID()).setDomainViolations(Collections.singletonList(v)).build())
                .collect(Collectors.toList());
    }
{code}





> [DMN Designer] Do not group V&V messages by UUID
> ------------------------------------------------
>
>                 Key: DROOLS-4807
>                 URL: https://issues.redhat.com/browse/DROOLS-4807
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>    Affects Versions: 7.30.0.Final
>            Reporter: Michael Anstis
>            Assignee: Michael Anstis
>            Priority: Major
>              Labels: drools-tools
>         Attachments: V&V.png
>
>
> The V&V results are grouped by UUID. See attached screen-shot.
> These items are reported individually by {{kie-dmn-validation}} but grouped by {{org.kie.workbench.common.dmn.showcase.backend.validation.ValidationServiceImpl}} in the _standalone_ webapp however I fear Stunner's generic {{ValidationService}} does the same in Business Central and hence reporting DMN V&V per-line may be more troublesum.
> See [here|https://github.com/kiegroup/kie-wb-common/blob/master/kie-wb-common-dmn/kie-wb-common-dmn-webapp-standalone/src/main/java/org/kie/workbench/common/dmn/showcase/backend/validation/ValidationServiceImpl.java#L56] that should more correctly be:-
> {code}
>     @Override
>     public Collection<DiagramElementViolation<RuleViolation>> validate(Diagram diagram) {
>         return domainViolations(diagram).stream()
>                 .filter(v -> Objects.nonNull(v.getUUID()))
>                 .filter(v -> !"null".equals(v.getUUID()))
>                 .map(v -> new ElementViolationImpl.Builder().setUuid(v.getUUID()).setDomainViolations(Collections.singletonList(v)).build())
>                 .collect(Collectors.toList());
>     }
> {code}
> h3. Acceptance criteria
> - Create a DMN file
> - Add a Decision node with no content
> - Validate it
> - Each validation message should be a separate item in the Alert panel



--
This message was sent by Atlassian Jira
(v7.13.8#713008)