[jboss-jira] [JBoss JIRA] (DROOLS-1781) Investigate possible replacement of findbugs-maven-plugin with spotbugs-maven-plugin

[Michael Biarnes Kiefer (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693089#comment-13693089 ] 

Michael Biarnes Kiefer commented on DROOLS-1781:
------------------------------------------------

[~manaRH] [~gdesmet]
There are a bunch of [PRs|https://github.com/kiegroup/droolsjbpm-build-bootstrap/pull/921] that replace the findbugs plugin by spotbugs plugin.
Two of them [kie-wb-common|https://github.com/kiegroup/kie-wb-common/pull/2444/files] and [drools-wb|https://github.com/kiegroup/drools-wb/pull/1058/files]
have bought in a filed (spotbugs-exclude.xml) to "filter" one bug detected by spotbugs plugin. So I ma not sure if I did it well.
Maybe it is better to change this directly in the code - but this has to be done then by a developer. 



> Investigate possible replacement of findbugs-maven-plugin with spotbugs-maven-plugin
> ------------------------------------------------------------------------------------
>
>                 Key: DROOLS-1781
>                 URL: https://issues.jboss.org/browse/DROOLS-1781
>             Project: Drools
>          Issue Type: Task
>          Components: build
>    Affects Versions: 7.4.1.Final
>            Reporter: Petr Široký
>            Assignee: Michael Biarnes Kiefer
>            Priority: Major
>              Labels: java9
>
> SpotBugs is a successor of FingBugs and as such uses different groupId + artifactId for maven plugin. It should also be compatible with Java 9 (at least in the latest versions). We need to investigate it the switch is painless and if so, do it. Otherwise we need to figure out what the blockers are and slowly start to fix them as FindBugs itself won't bet any more updates it seems and so won't be Java 9 compatible.
> *How to migrate*
> * Replace 
> {code}
>         <groupId>org.codehaus.mojo</groupId>
>         <artifactId>findbugs-maven-plugin</artifactId>
> {code}
> by
> {code}
>         <groupId>com.github.spotbugs</groupId>
>         <artifactId>spotbugs-maven-plugin</artifactId>
> {code}
> * Look for all "findbugs" and replace it by "spotbugs"
> ** Except for anything related to the findbugs annotations dependency that some dependencies drag in or exclude. Leave that one alone!
> ** For example, change findbugs-check -> spotbugs-check, ...
> * Merge this PR if it hasn't been merged already: https://github.com/kiegroup/optaplanner-wb/pull/320
> * Then you only need to adjust the following repo's: build-boostrap, drools, optaplanner and kie-wb-distributions.
> ** See https://github.com/search?q=org%3Akiegroup+findbugs-maven-plugin&type=Code
> ** Ignore contributed experiments, that repo is dead



--
This message was sent by Atlassian Jira
(v7.12.1#712002)