[jboss-jira] [JBoss JIRA] (WFLY-11710) Datasource metrics are not always exposed by the metrics subsystem

[Brian Stansberry (Jira)]

    [ https://issues.jboss.org/browse/WFLY-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699613#comment-13699613 ] 

Brian Stansberry commented on WFLY-11710:
-----------------------------------------

Perhaps the MetricsRegistrationService collection of the root resource tree metrics could be moved out of start and called by MicroProfileMetricsSubsystemAdd in Stage.VERIFY. That's still an abuse of VERIFY but it doesn't involve adding a new service outside RUNTIME which I think the first approach to VERIFY did.  We could say MetricsRegistrationService is "verifying" the runtime state by scanning for metrics. ;)

> Datasource metrics are not always exposed by the metrics subsystem
> ------------------------------------------------------------------
>
>                 Key: WFLY-11710
>                 URL: https://issues.jboss.org/browse/WFLY-11710
>             Project: WildFly
>          Issue Type: Bug
>          Components: MP Metrics
>    Affects Versions: 16.0.0.Beta1
>            Reporter: Jeff Mesnil
>            Assignee: Jeff Mesnil
>            Priority: Critical
>             Fix For: 16.0.0.CR1
>
>
> The metrics subsystem install a service at RUNTIME to register any metrics on the resources registered in WildFly management tree.
> However, the metrics for datasources are provided by the statistics=jdbc and statistics=pool children of the datasource resource which are installed at RUNTIME.
> Since there is no dependency between the metrics service and the service that installs the datasource statistics, it is possible that the metrics services is started before and while traverse the WildFly management tree before the statistics resources are added to it.
> This issue is intermittent and depend on the sequence of execution of unrelated services.
> To circumvent this issue, the metrics subsystem could install its service at VERIFY stage (instead of RUNTIME) and will then have the guarantee that any resources created at RUNTIME is present in WildFly management tree.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)