[jboss-jira] [JBoss JIRA] (WFCORE-4276) Audit and if possible eliminate overrides of SimpleResourceDefinition.registerCapabilities

[Jeff Mesnil (Jira)]

     [ https://issues.jboss.org/browse/WFCORE-4276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Mesnil moved WFLY-11589 to WFCORE-4276:
--------------------------------------------

        Project: WildFly Core  (was: WildFly)
            Key: WFCORE-4276  (was: WFLY-11589)
    Component/s: Management
                     (was: Management)


> Audit and if possible eliminate overrides of SimpleResourceDefinition.registerCapabilities
> ------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-4276
>                 URL: https://issues.jboss.org/browse/WFCORE-4276
>             Project: WildFly Core
>          Issue Type: Task
>          Components: Management
>            Reporter: Brian Stansberry
>            Assignee: Jeff Mesnil
>            Priority: Major
>
> Overriding SimpleResourceDefinition.registerCapabilities is risky because if the superclass impl is not called, any caps registered in any Parameters object passed to the constructor will not be registered. Since we are tending to move using Parameters, leaving custom overrides around is a potential bug source. This is what happened with WFLY-11587.
> In many cases the registerCapabilities override is just doing what using Parameters would have done, so this task is basically to upgrade this code.  If there's some specific reason why an override is still needed in some class, that's ok, but then consideration should be given to also calling the superclass impl, if it's not already being done.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)