[jboss-jira] [JBoss JIRA] (DROOLS-3546) DMN fix FEEL context entry when key is a string literal

Matteo Mortari (Jira) issues at jboss.org
Thu Jan 24 04:43:00 EST 2019


    [ https://issues.jboss.org/browse/DROOLS-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686958#comment-13686958 ] 

Matteo Mortari commented on DROOLS-3546:
----------------------------------------

> I am approving this PR because I see in the FEEL grammar it supports string literals as keys, but I think this is a mistake in the spec.

Before I will close this JIRA, I want to verify what is actually implied by "mistake in the spec".
DMNv1.1:
 !screenshot-1.png|thumbnail! 
and specific chapter:
 !screenshot-2.png|thumbnail! 

DMNv1.2:
 !screenshot-3.png|thumbnail! 
and the specific chapter:
 !screenshot-4.png|thumbnail! 

So I believe it not only the FEEL grammar that specify this, but it is also backed by the specific Context chapter on the matter.

Personally, although I still would need to triple check it, I believe the spec included this "feature" to enable the FEEL-only equivalent of this:
 !screenshot-5.png|thumbnail! 
as I believe the horse-emoji would be a valid FEEL name by intentions, but the unicode is not compatible with grammar rule "30. name start char"

What do you think [~tirelli] ?

> DMN fix FEEL context entry when key is a string literal
> -------------------------------------------------------
>
>                 Key: DROOLS-3546
>                 URL: https://issues.jboss.org/browse/DROOLS-3546
>             Project: Drools
>          Issue Type: Bug
>          Components: dmn engine
>            Reporter: Matteo Mortari
>            Assignee: Matteo Mortari
>            Priority: Major
>         Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png, screenshot-4.png, screenshot-5.png
>
>
> Ref FEEL grammar rule 61



--
This message was sent by Atlassian Jira
(v7.12.1#712002)


More information about the jboss-jira mailing list