[jboss-jira] [JBoss JIRA] (WFLY-11983) Unify line-endings of bat scripts (regression against WF15)

[Radoslav Husar (Jira)]

    [ https://issues.jboss.org/browse/WFLY-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741760#comment-13741760 ] 

Radoslav Husar commented on WFLY-11983:
---------------------------------------

Looking at Beta1, this is also problem for our ps1 scripts. I will update the PR.

{noformat}
[rhusar at ribera wildfly-17.0.0.Beta1]$ find . | grep ps1$ | xargs file
./bin/add-user.ps1:        ASCII text
./bin/jdr.ps1:             ASCII text
./bin/standalone.ps1:      ASCII text
./bin/common.ps1:          ASCII text
./bin/appclient.conf.ps1:  ASCII text
./bin/appclient.ps1:       ASCII text
./bin/wsprovide.ps1:       ASCII text
./bin/jconsole.ps1:        ASCII text
./bin/elytron-tool.ps1:    ASCII text
./bin/domain.ps1:          ASCII text
./bin/domain.conf.ps1:     ASCII text
./bin/jboss-cli.ps1:       ASCII text
./bin/wsconsume.ps1:       ASCII text
./bin/standalone.conf.ps1: ASCII text
./bin/vault.ps1:           ASCII text
[rhusar at ribera wildfly-17.0.0.Beta1]$ find . | grep bat$ | xargs file
./bin/add-user.bat:                         DOS batch file text, ASCII text
./bin/jdr.bat:                              DOS batch file text, ASCII text
./bin/standalone.bat:                       DOS batch file text, ASCII text, with CRLF line terminators
./bin/appclient.bat:                        DOS batch file text, ASCII text, with CRLF line terminators
./bin/wsprovide.bat:                        DOS batch file text, ASCII text, with CRLF line terminators
./bin/appclient.conf.bat:                   ASCII text, with CRLF line terminators
./bin/common.bat:                           DOS batch file text, ASCII text, with CRLF line terminators
./bin/elytron-tool.bat:                     DOS batch file text, ASCII text
./bin/jconsole.bat:                         DOS batch file text, ASCII text
./bin/domain.bat:                           DOS batch file text, ASCII text, with CRLF line terminators
./bin/wsconsume.bat:                        DOS batch file text, ASCII text, with CRLF line terminators
./bin/standalone.conf.bat:                  ASCII text, with CRLF line terminators
./bin/domain.conf.bat:                      ASCII text, with CRLF line terminators
./bin/jboss-cli.bat:                        DOS batch file text, ASCII text
./bin/vault.bat:                            DOS batch file text, ASCII text, with CRLF line terminators
./docs/contrib/scripts/service/service.bat: DOS batch file text, ASCII text, with very long lines, with CRLF line terminators
{noformat}

> Unify line-endings of bat scripts (regression against WF15)
> -----------------------------------------------------------
>
>                 Key: WFLY-11983
>                 URL: https://issues.jboss.org/browse/WFLY-11983
>             Project: WildFly
>          Issue Type: Bug
>          Components: Scripts
>    Affects Versions: 16.0.0.Final
>            Reporter: Marek Kopecky
>            Assignee: Radoslav Husar
>            Priority: Critical
>
> Line-endings of bat scripts should be unified. This is regression against WF15.
> Some files in WF16 uses CRLF, another LF only. We need to clarify the recommended line ending and use this line ending in all Windows scripts.
> WF16:
> {noformat}
> $ find | grep bat$ | xargs file
> ./wsprovide.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./jboss-cli.bat:       DOS batch file, ASCII text
> ./elytron-tool.bat:    DOS batch file, ASCII text
> ./domain.bat:          DOS batch file, ASCII text, with CRLF line terminators
> ./wsconsume.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./standalone.bat:      DOS batch file, ASCII text, with CRLF line terminators
> ./vault.bat:           DOS batch file, ASCII text, with CRLF line terminators
> ./domain.conf.bat:     ASCII text, with CRLF line terminators
> ./common.bat:          DOS batch file, ASCII text, with CRLF line terminators
> ./jdr.bat:             DOS batch file, ASCII text
> ./jconsole.bat:        DOS batch file, ASCII text
> ./appclient.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.conf.bat:  ASCII text, with CRLF line terminators
> ./standalone.conf.bat: ASCII text, with CRLF line terminators
> ./add-user.bat:        DOS batch file, ASCII text
> $ 
> {noformat}
> WF15:
> {noformat}
> $ find | grep bat$ | xargs file
> ./wsprovide.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./jboss-cli.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./elytron-tool.bat:    DOS batch file, ASCII text, with CRLF line terminators
> ./domain.bat:          DOS batch file, ASCII text, with CRLF line terminators
> ./wsconsume.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./standalone.bat:      DOS batch file, ASCII text, with CRLF line terminators
> ./vault.bat:           DOS batch file, ASCII text, with CRLF line terminators
> ./domain.conf.bat:     ASCII text, with CRLF line terminators
> ./common.bat:          DOS batch file, ASCII text, with CRLF line terminators
> ./jdr.bat:             DOS batch file, ASCII text, with CRLF line terminators
> ./jconsole.bat:        DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.conf.bat:  ASCII text, with CRLF line terminators
> ./standalone.conf.bat: ASCII text, with CRLF line terminators
> ./add-user.bat:        DOS batch file, ASCII text, with CRLF line terminators
> $ 
> {noformat}



--
This message was sent by Atlassian Jira
(v7.12.1#712002)