[jboss-jira] [JBoss JIRA] (WFCORE-4502) Unify line-endings of bat scripts (regression against WF15)
James Perkins (Jira)
issues at jboss.org
Mon Jun 3 17:30:00 EDT 2019
[ https://issues.jboss.org/browse/WFCORE-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741895#comment-13741895 ]
James Perkins edited comment on WFCORE-4502 at 6/3/19 5:29 PM:
---------------------------------------------------------------
It does look like feature pack plugin is [configured|https://github.com/wildfly/wildfly-core/blob/b46df00dabdc409b25ffe6b92c5fab1a1923ed0b/core-feature-pack/feature-pack-build.xml#L77-L85] to change the line endings. However it looks like those line endings get lost somehow when the feature pack is brought into full.
{code:title=core-feature-pack}
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/add-user.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/standalone.conf.bat: ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/elytron-tool.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/domain.conf.bat: ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/domain.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/common.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/vault.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/jboss-cli.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/docs/contrib/scripts/service/service.bat: DOS batch file, ASCII text, with very long lines, with CRLF line terminators
{code}
{code:title=build}
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/add-user.bat: DOS batch file, ASCII text
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/standalone.conf.bat: ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/wsconsume.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/jdr.bat: DOS batch file, ASCII text
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/wsprovide.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/elytron-tool.bat: DOS batch file, ASCII text
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/jconsole.bat: DOS batch file, ASCII text
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/appclient.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/domain.conf.bat: ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/domain.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/appclient.conf.bat: ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/common.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/vault.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/jboss-cli.bat: DOS batch file, ASCII text
./target/wildfly-17.0.0.Final-SNAPSHOT/docs/contrib/scripts/service/service.bat: DOS batch file, ASCII text, with very long lines, with CRLF line terminators
{code}
We may want to also file a WFBUILD issue for this as well. We might also want to add {{*.ps1}} files to the windows line endings.
was (Author: jamezp):
It does look like feature pack plugin is [configured|https://github.com/wildfly/wildfly-core/blob/b46df00dabdc409b25ffe6b92c5fab1a1923ed0b/core-feature-pack/feature-pack-build.xml#L77-L85] to change the line endings. However it looks like those line endings get lost somehow when the feature pack is brought into full.
{code:title=core-feature-pack}
/target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/add-user.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/standalone.conf.bat: ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/elytron-tool.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/domain.conf.bat: ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/domain.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/common.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/vault.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/bin/jboss-cli.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-core-feature-pack-9.0.0.Beta8-SNAPSHOT/content/docs/contrib/scripts/service/service.bat: DOS batch file, ASCII text, with very long lines, with CRLF line terminators
{code}
{code:title=build}
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/add-user.bat: DOS batch file, ASCII text
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/standalone.conf.bat: ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/wsconsume.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/jdr.bat: DOS batch file, ASCII text
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/wsprovide.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/elytron-tool.bat: DOS batch file, ASCII text
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/jconsole.bat: DOS batch file, ASCII text
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/appclient.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/domain.conf.bat: ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/domain.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/appclient.conf.bat: ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/common.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/vault.bat: DOS batch file, ASCII text, with CRLF line terminators
./target/wildfly-17.0.0.Final-SNAPSHOT/bin/jboss-cli.bat: DOS batch file, ASCII text
./target/wildfly-17.0.0.Final-SNAPSHOT/docs/contrib/scripts/service/service.bat: DOS batch file, ASCII text, with very long lines, with CRLF line terminators
{code}
We may want to also file a WFBUILD issue for this as well. We might also want to add {{*.ps1}} files to the windows line endings.
> Unify line-endings of bat scripts (regression against WF15)
> -----------------------------------------------------------
>
> Key: WFCORE-4502
> URL: https://issues.jboss.org/browse/WFCORE-4502
> Project: WildFly Core
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 9.0.0.Beta7
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Priority: Critical
>
> Line-endings of bat scripts should be unified. This is regression against WF15.
> Some files in WF16 uses CRLF, another LF only. We need to clarify the recommended line ending and use this line ending in all Windows scripts.
> WF16:
> {noformat}
> $ find | grep bat$ | xargs file
> ./wsprovide.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./jboss-cli.bat: DOS batch file, ASCII text
> ./elytron-tool.bat: DOS batch file, ASCII text
> ./domain.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./wsconsume.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./vault.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./domain.conf.bat: ASCII text, with CRLF line terminators
> ./common.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./jdr.bat: DOS batch file, ASCII text
> ./jconsole.bat: DOS batch file, ASCII text
> ./appclient.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.conf.bat: ASCII text, with CRLF line terminators
> ./standalone.conf.bat: ASCII text, with CRLF line terminators
> ./add-user.bat: DOS batch file, ASCII text
> $
> {noformat}
> WF15:
> {noformat}
> $ find | grep bat$ | xargs file
> ./wsprovide.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./jboss-cli.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./elytron-tool.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./domain.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./wsconsume.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./vault.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./domain.conf.bat: ASCII text, with CRLF line terminators
> ./common.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./jdr.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./jconsole.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.conf.bat: ASCII text, with CRLF line terminators
> ./standalone.conf.bat: ASCII text, with CRLF line terminators
> ./add-user.bat: DOS batch file, ASCII text, with CRLF line terminators
> $
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
More information about the jboss-jira
mailing list