[jboss-jira] [JBoss JIRA] (DROOLS-4138) Building a KJAR using Decision Table Templates throws NPE

[Carl Mes (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744753#comment-13744753 ] 

Carl Mes commented on DROOLS-4138:
----------------------------------

I've updated the reproducer code to include the kmodule configuration code, and the example decision table templates now work great!

However I've run into another snag where the KieBaseModel doesn't appear to have a method for setting "trimCell" to FALSE (the default is TRUE). I have updated the reproducer code to include a trimCell test (a simplified version of the rules in use at the customer site): https://github.com/carlmes/decision-table-template/blob/master/src/main/resources/trimCell-template-test/trim-cell-test.drt#L17

Do you have any suggestions about how I could ensure that trimCell attribute gets passed through to the ExternalSpreadsheetCompiler, and the empty cells are not omitted from the generated DRL output?

> Building a KJAR using Decision Table Templates throws NPE
> ---------------------------------------------------------
>
>                 Key: DROOLS-4138
>                 URL: https://issues.jboss.org/browse/DROOLS-4138
>             Project: Drools
>          Issue Type: Bug
>          Components: core engine
>    Affects Versions: 7.18.0.Final, 7.23.0.Final
>            Reporter: Carl Mes
>            Assignee: Mario Fusco
>            Priority: Major
>         Attachments: DecisionTableConfigurationImpl.java
>
>
> Steps to building a new KJar by defining Resource objects and adding then using KieFileSystem.write(), if a Decision Table Template resource type is added then we get a null pointer exception when the KieBuilder.buildAll() method is invoked.
> Sample code that demonstrates this error can be found here: https://github.com/carlmes/decision-table-template, specifically the notes in [TestDecisionTableBuild.java|https://github.com/carlmes/decision-table-template/blob/a68ddd1374f08695fe8d770f0b89bdf76d806e71/src/test/java/test/kjar/build/TestDecisionTableBuild.java#L70].
> Red Hat support case: https://access.redhat.com/support/cases/#/case/02397413
> I have created a proposed fix in [DecisionTableConfigurationImpl.java|https://github.com/kiegroup/drools/blob/f1091fb26d524b99632bad81497e8ad461e9d13f/drools-core/src/main/java/org/drools/core/builder/conf/impl/DecisionTableConfigurationImpl.java#L86], by implementing the missing properties in the fromProperties and toProperties methods. Please see attached updated file that has been tested to fix the issue locally.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)