[jboss-jira] [JBoss JIRA] (WFLY-10554) OpenSAML 3.3.0 complains for missing class from "metrics-core"

[Jim Ma (Jira)]

    [ https://issues.jboss.org/browse/WFLY-10554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746158#comment-13746158 ] 

Jim Ma edited comment on WFLY-10554 at 6/13/19 12:03 AM:
---------------------------------------------------------

[~rady66]  You can directly modify the module.xml for "some module" like this : 

{code:xml}
<module name="some module" xmlns="urn:jboss:module:1.5">
    <resources>
         <resource-root path="dropwizard.jar"/>
        ....
     </resources>
    <dependencies>
        <module name="org.opensaml" export="true" services="export"/>
        ...
  </dependencies>
....
</module>
{code}

For the functional thing ,  I agree with you  and this should not be taking care by user by adding another module. But here the metrics dependency is actually not a core or functional dependency for opensaml if you look at [wssecurity code|https://github.com/apache/wss4j/blob/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/saml/OpenSAMLUtil.java#L78] to configure and initialize opensaml. It should be some optional feature instead of being initialized by default. 


was (Author: jim.ma):
[~rady66]  You can directly modify the module.xml for "some module" like this : 

{code:xml}
<module name="some module" xmlns="urn:jboss:module:1.5">
    <resources>
         <resource-root path="dropwizard.jar"/>
        ....
     </resources>
    <dependencies>
        <module name="org.opensaml" export="true" services="export"/>
        ...
  </dependencies>
....
</module>
{code}

For the functional thing ,  I agree with you  and this should not be taking care by user by adding another module. But here the metrics dependency is actually not a core or functional dependency for opensaml if you look at [wssecurity code|https://github.com/apache/wss4j/blob/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/saml/OpenSAMLUtil.java#L78] to configure and initialize opensaml. It should be some optional feature instead of initial by default. 

> OpenSAML 3.3.0 complains for missing class from "metrics-core"
> --------------------------------------------------------------
>
>                 Key: WFLY-10554
>                 URL: https://issues.jboss.org/browse/WFLY-10554
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web Services
>    Affects Versions: 13.0.0.Final
>            Reporter: Radoslav Ivanov
>            Assignee: Jim Ma
>            Priority: Critical
>         Attachments: screenshot-1.png
>
>
> Module OpenSAML 3.3.0 requires depedency to module "io.dropwizard.metrics:metrics-core" but it does not present. As a result ClassNotFoundException is thrown.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)