[jboss-jira] [JBoss JIRA] (WFCORE-4525) Fix failing tests on IBM JDK

[Richard Opalka (Jira)]

    [ https://issues.jboss.org/browse/WFCORE-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746383#comment-13746383 ] 

Richard Opalka edited comment on WFCORE-4525 at 6/13/19 8:47 AM:
-----------------------------------------------------------------

I was able to fix some tests applying the following patch on maven surefire upstream:

{code}
blackhole][/home/opalka/git/apache/maven-surefire]>git diff
diff --git a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
index ebc1b276..5ec0e4ea 100644
--- a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
+++ b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
@@ -83,9 +83,9 @@ private void setupBooter( String tmpDir, String dumpFileName, String surefirePro
     {
         BooterDeserializer booterDeserializer =
                 new BooterDeserializer( createSurefirePropertiesIfFileExists( tmpDir, surefirePropsFileName ) );
+        setSystemProperties( new File( tmpDir, effectiveSystemPropertiesFileName ) );
         // todo: print PID in debug console logger in version 2.21.2
         pingScheduler = isDebugging() ? null : listenToShutdownCommands( booterDeserializer.getPluginPid() );
-        setSystemProperties( new File( tmpDir, effectiveSystemPropertiesFileName ) );
 
         providerConfiguration = booterDeserializer.deserialize();
         DumpErrorSingleton.getSingleton()
{code}


was (Author: ropalka):
I was able to fix some tests applying the following patch on maven surefire upstream:

{quote}
blackhole][/home/opalka/git/apache/maven-surefire]>git diff
diff --git a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
index ebc1b276..5ec0e4ea 100644
--- a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
+++ b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
@@ -83,9 +83,9 @@ private void setupBooter( String tmpDir, String dumpFileName, String surefirePro
     {
         BooterDeserializer booterDeserializer =
                 new BooterDeserializer( createSurefirePropertiesIfFileExists( tmpDir, surefirePropsFileName ) );
+        setSystemProperties( new File( tmpDir, effectiveSystemPropertiesFileName ) );
         // todo: print PID in debug console logger in version 2.21.2
         pingScheduler = isDebugging() ? null : listenToShutdownCommands( booterDeserializer.getPluginPid() );
-        setSystemProperties( new File( tmpDir, effectiveSystemPropertiesFileName ) );
 
         providerConfiguration = booterDeserializer.deserialize();
         DumpErrorSingleton.getSingleton()
{quote}

> Fix failing tests on IBM JDK
> ----------------------------
>
>                 Key: WFCORE-4525
>                 URL: https://issues.jboss.org/browse/WFCORE-4525
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Logging
>            Reporter: Richard Opalka
>            Assignee: James Perkins
>            Priority: Major
>             Fix For: 9.0.2.Final
>
>         Attachments: forked-booter.png, ibm-jdk8.png, oracle-jdk.png
>
>
> The following tests are failing on latest IBM JDK 8:
> ---
> # testsuite/standalone
> SilentModeTestCase
> # testsuite/manualmode
> CLIEmbedHostControllerTestCase
> CLIEmbedServerTestCase
> ---
> Tested on:
> ---
> java version "1.8.0_211"
> Java(TM) SE Runtime Environment (build 8.0.5.36 - pxa6480sr5fp36-20190510_01(SR5 FP36))
> IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190502_415899 (JIT enabled, AOT enabled)
> OpenJ9   - 46e57f9
> OMR      - 06a046a
> IBM      - 0b909bf)
> JCL - 20190409_01 based on Oracle jdk8u211-b25
> ---



--
This message was sent by Atlassian Jira
(v7.12.1#712002)