[jboss-jira] [JBoss JIRA] (WFLY-11983) Unify line-endings of bat scripts (regression against WF15)

[James Perkins (Jira)]

    [ https://issues.jboss.org/browse/WFLY-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748601#comment-13748601 ] 

James Perkins commented on WFLY-11983:
--------------------------------------

You are correct the files themselves need to be updated. You'd have to apply this change then do something like {{find feature-pack/src -name "*.bat" | xargs git reset-file}}. Every user would have to do this though or more importantly whoever does the release.

That said there is also WFGP-144 which fixes this issue with the changes on the [WFCORE-4502|https://issues.jboss.org/browse/WFCORE-4502?focusedCommentId=13741905&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13741905] comment.

> Unify line-endings of bat scripts (regression against WF15)
> -----------------------------------------------------------
>
>                 Key: WFLY-11983
>                 URL: https://issues.jboss.org/browse/WFLY-11983
>             Project: WildFly
>          Issue Type: Bug
>          Components: Scripts
>    Affects Versions: 16.0.0.Final
>            Reporter: Marek Kopecky
>            Assignee: Radoslav Husar
>            Priority: Major
>
> Line-endings of bat scripts should be unified. This is regression against WF15.
> Some files in WF16 uses CRLF, another LF only. We need to clarify the recommended line ending and use this line ending in all Windows scripts.
> WF16:
> {noformat}
> $ find | grep bat$ | xargs file
> ./wsprovide.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./jboss-cli.bat:       DOS batch file, ASCII text
> ./elytron-tool.bat:    DOS batch file, ASCII text
> ./domain.bat:          DOS batch file, ASCII text, with CRLF line terminators
> ./wsconsume.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./standalone.bat:      DOS batch file, ASCII text, with CRLF line terminators
> ./vault.bat:           DOS batch file, ASCII text, with CRLF line terminators
> ./domain.conf.bat:     ASCII text, with CRLF line terminators
> ./common.bat:          DOS batch file, ASCII text, with CRLF line terminators
> ./jdr.bat:             DOS batch file, ASCII text
> ./jconsole.bat:        DOS batch file, ASCII text
> ./appclient.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.conf.bat:  ASCII text, with CRLF line terminators
> ./standalone.conf.bat: ASCII text, with CRLF line terminators
> ./add-user.bat:        DOS batch file, ASCII text
> $ 
> {noformat}
> WF15:
> {noformat}
> $ find | grep bat$ | xargs file
> ./wsprovide.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./jboss-cli.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./elytron-tool.bat:    DOS batch file, ASCII text, with CRLF line terminators
> ./domain.bat:          DOS batch file, ASCII text, with CRLF line terminators
> ./wsconsume.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./standalone.bat:      DOS batch file, ASCII text, with CRLF line terminators
> ./vault.bat:           DOS batch file, ASCII text, with CRLF line terminators
> ./domain.conf.bat:     ASCII text, with CRLF line terminators
> ./common.bat:          DOS batch file, ASCII text, with CRLF line terminators
> ./jdr.bat:             DOS batch file, ASCII text, with CRLF line terminators
> ./jconsole.bat:        DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.bat:       DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.conf.bat:  ASCII text, with CRLF line terminators
> ./standalone.conf.bat: ASCII text, with CRLF line terminators
> ./add-user.bat:        DOS batch file, ASCII text, with CRLF line terminators
> $ 
> {noformat}



--
This message was sent by Atlassian Jira
(v7.12.1#712002)