[jboss-jira] [JBoss JIRA] (WFLY-11827) Broken validation for pooled-connection-factory's transaction attribute.

[Petr Kremensky (Jira)]

    [ https://issues.jboss.org/browse/WFLY-11827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706278#comment-13706278 ] 

Petr Kremensky edited comment on WFLY-11827 at 3/11/19 5:18 AM:
----------------------------------------------------------------

I've submit an MR for fixing the problem of validation where the attribute value is 'xa'. Not sure about the other part of the issue.

{noformat}
[standalone at localhost:9990 /] /subsystem=messaging-activemq/server=default/pooled-connection-factory=activemq-ra:write-attribute(name=transaction,value=asd)
10:16:58,115 WARN  [org.wildfly.extension.messaging-activemq] (management-handler-thread - 1) WFLYMSGAMQ0101: Invalid value asd for transaction, legal values are [local, none, xa], default value is applied.
{"outcome" => "success"}

[standalone at localhost:9990 /]  /subsystem=messaging-activemq/server=default/pooled-connection-factory=activemq-ra:read-attribute(name=transaction)
{
    "outcome" => "success",
    "result" => "xa"
}
{noformat}
[~soul2zimate] this behaviour is imho wrong, wdyt?


was (Author: pkremens):
I've submit an MR for fixing the problem of validation where the attribute value is 'xa'. Not sure about the other part of the issue.

[~soul2zimate]
{noformat}
[standalone at localhost:9990 /] /subsystem=messaging-activemq/server=default/pooled-connection-factory=activemq-ra:write-attribute(name=transaction,value=asd)
10:16:58,115 WARN  [org.wildfly.extension.messaging-activemq] (management-handler-thread - 1) WFLYMSGAMQ0101: Invalid value asd for transaction, legal values are [local, none, xa], default value is applied.
{"outcome" => "success"}

[standalone at localhost:9990 /]  /subsystem=messaging-activemq/server=default/pooled-connection-factory=activemq-ra:read-attribute(name=transaction)
{
    "outcome" => "success",
    "result" => "xa"
}
{noformat}
This behaviour is imho wrong,

> Broken validation for pooled-connection-factory's transaction attribute. 
> -------------------------------------------------------------------------
>
>                 Key: WFLY-11827
>                 URL: https://issues.jboss.org/browse/WFLY-11827
>             Project: WildFly
>          Issue Type: Bug
>          Components: JMS
>    Affects Versions: 16.0.0.Final
>            Reporter: Petr Kremensky
>            Assignee: Chao Wang
>            Priority: Major
>
> The issue was introduced by https://issues.jboss.org/browse/WFLY-11617 Validation not working for pooled-connection-factory's transaction attribute. 
> *1) Starting Wildfly with _full_ profile gives now a WARN log, although the value for the transaction attribute is valid.*
> *2) Writing the invalid value to the attribute should fail the management operation.*
> Starting vanilla server:
> {noformat}
> 09:19:00,578 WARN  [org.wildfly.extension.messaging-activemq] (ServerService Thread Pool -- 18) WFLYMSGAMQ0101: Invalid value xa for transaction, legal values are [local, none, xa], default value is applied.
> {noformat}
> Write operation:
> {noformat}
> [standalone at localhost:9990 /] /subsystem=messaging-activemq/server=default/pooled-connection-factory=activemq-ra:write-attribute(name=transaction,value=xa)
> 09:31:21,542 WARN  [org.wildfly.extension.messaging-activemq] (management-handler-thread - 2) WFLYMSGAMQ0101: Invalid value xa for transaction, legal values are [local, none, xa], default value is applied.
> {"outcome" => "success"}
> [standalone at localhost:9990 /] /subsystem=messaging-activemq/server=default/pooled-connection-factory=activemq-ra:write-attribute(name=transaction,value=invalid)
> 09:33:52,278 WARN  [org.wildfly.extension.messaging-activemq] (management-handler-thread - 1) WFLYMSGAMQ0101: Invalid value invalid for transaction, legal values are [local, none, xa], default value is applied.
> {"outcome" => "success"}
> [standalone at localhost:9990 /]  /subsystem=messaging-activemq/server=default/pooled-connection-factory=activemq-ra:read-attribute(name=transaction)
> {
>     "outcome" => "success",
>     "result" => "xa"
> }
> {noformat}
> Start (not reload, reload gives a single warning) server with invalid value logs two warnings:
> {noformat}
> ...
> 09:35:37,737 INFO  [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: WildFly Full 16.0.0.Final (WildFly Core 8.0.0.Final) starting
> 09:35:38,481 INFO  [org.wildfly.security] (ServerService Thread Pool -- 15) ELY00001: WildFly Elytron version 1.8.0.Final
> 09:35:38,688 WARN  [org.wildfly.extension.messaging-activemq] (Controller Boot Thread) WFLYMSGAMQ0101: Invalid value foo for transaction, legal values are ["local", "none", "xa"], default value is applied.
> 09:35:38,945 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/core-service=management/management-interface=http-interface' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
> 09:35:38,979 WARN  [org.wildfly.extension.messaging-activemq] (ServerService Thread Pool -- 7) WFLYMSGAMQ0101: Invalid value foo for transaction, legal values are [local, none, xa], default value is applied.
> 09:35:38,980 INFO  [org.jboss.as.controller.management-deprecated] (ServerService Thread Pool -- 38) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
> ...
> {noformat}



--
This message was sent by Atlassian Jira
(v7.12.1#712002)