[jboss-jira] [JBoss JIRA] (WFLY-12019) Cannot remove a undertow server resource at one time

[Brian Stansberry (Jira)]

    [ https://issues.jboss.org/browse/WFLY-12019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730271#comment-13730271 ] 

Brian Stansberry commented on WFLY-12019:
-----------------------------------------

[~spyrkob] FWIW, I just noticed this:

{code}
[standalone at embedded /] /subsystem=undertow/server=default-server/host=default-host:read-operation-description(name=remove)
{
    "outcome" => "success",
    "result" => {
        "operation-name" => "remove",
        "description" => "Removes a host",
        "request-properties" => {},
        "reply-properties" => {},
        "read-only" => false,
        "restart-required" => "all-services",
        "runtime-only" => false
    }
}
{code}

 "restart-required" => "all-services"

IOW, the entire HostRemove handler is one big bug. It should not be removing services when its description says it won't. The resource can use ReloadRequiredRemoveStepHandler.

If that were changed, because the remove ops for filter-ref and single-sign-on child resources declare they do support removing services if allow-resource-service-restart=true is true is set, you can get some mixed behavior due to WFCORE-1483 if this is invoked:

/subsystem=undertow/server=default-server/host=test-host:remove{allow-resource-service-restart=true}

The services associated with the filter-ref and sso children will be removed while the other services associated with the resource tree will remain.

That's a corner case though, and really allow-resource-service-restart=true is an expert setting where the user declares they understand what they are doing.

> Cannot remove a undertow server resource at one time
> ----------------------------------------------------
>
>                 Key: WFLY-12019
>                 URL: https://issues.jboss.org/browse/WFLY-12019
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web (Undertow)
>    Affects Versions: 16.0.0.Final
>            Reporter: Bartosz Spyrko
>            Assignee: Bartosz Spyrko
>            Priority: Major
>
> Cannot remove a server attribute.
> {noformat}
> [standalone at localhost:9990 /] /subsystem=undertow/server=default-server:remove()
> {
>     "outcome" => "failed",
>     "failure-description" => "WFLYCTL0171: Removing services has lead to unsatisfied dependencies:
> Service jboss.undertow.server.default-server.default-host was depended upon by service jboss.undertow.server.default-server.default-host.filter-ref.x-powered-by-header, service jboss.undertow.server.default-server.default-host.location.
> /, service jboss.undertow.server.default-server.default-host.filter-ref.server-header",                                                                                                                                                    
>     "rolled-back" => true,
>     "response-headers" => undefined
> }
> {noformat}
> However, it can be removed executing same command again.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)