[jboss-jira] [JBoss JIRA] (DROOLS-3985) [DMN Editor] No Build Error about missing inputs for imported node
Jozef Marko (Jira)
issues at jboss.org
Tue May 7 07:55:00 EDT 2019
[ https://issues.jboss.org/browse/DROOLS-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jozef Marko updated DROOLS-3985:
--------------------------------
Description:
This Iss was spotted during review of [PR|https://github.com/kiegroup/kie-wb-common/pull/2620] for DROOLS-3829 and DROOLS-3934.
If user deploy a model with imported node, and this node miss inputs, no build error appears. However there is error if user tries to execute such model, for example via rest.
h3. Steps To Reproduce
# Deploy the attached project to kie server
# Try to execute the model as:
{code:sh}
curl -u testadmin:'admin1234;' -H "accept: application/json" -H "content-type: application/json" -X POST "http://localhost:8080/kie-server/services/rest/server/containers/dmn.imports/dmn" -d "{ \"model-namespace\" : \"https://github.com/kiegroup/drools/kie-dmn/_547C193C-0B52-45F5-877E-F74A7DD29838\", \"model-name\" : \"routes\", \"decision-name\" : [\"Traffic.Traffic\" ], \"decision-id\" : [ ], \"dmn-context\" : {\"Cars Per Hour\" : 10}}"
{code}
# You will get reuslt:
{code:json}
{
"type" : "SUCCESS",
"msg" : "OK from container 'dmn.imports'",
"result" : {
"dmn-evaluation-result" : {
"messages" : [ {
"dmn-message-severity" : "ERROR",
"message" : "Required dependency 'Cars Per Hour' not found on node 'Traffic'",
"message-type" : "REQ_NOT_FOUND",
"source-id" : "_6BA74389-CBF7-4D6A-99B1-9F494DCC323A"
} ],
"model-namespace" : "https://github.com/kiegroup/drools/kie-dmn/_547C193C-0B52-45F5-877E-F74A7DD29838",
"model-name" : "routes",
"decision-name" : "Traffic.Traffic",
"dmn-context" : {
"Cars Per Hour" : 10,
"Traffic" : { }
},
"decision-results" : {
"https://github.com/kiegroup/drools/kie-dmn/_1876D3A2-0972-4AE8-AF59-A56AD8D4FF5F#_6BA74389-CBF7-4D6A-99B1-9F494DCC323A" : {
"messages" : [ {
"dmn-message-severity" : "ERROR",
"message" : "Required dependency 'Cars Per Hour' not found on node 'Traffic'",
"message-type" : "REQ_NOT_FOUND",
"source-id" : "_6BA74389-CBF7-4D6A-99B1-9F494DCC323A"
} ],
"decision-id" : "https://github.com/kiegroup/drools/kie-dmn/_1876D3A2-0972-4AE8-AF59-A56AD8D4FF5F#_6BA74389-CBF7-4D6A-99B1-9F494DCC323A",
"decision-name" : "Traffic.Traffic",
"result" : null,
"status" : "SKIPPED"
}
}
}
}
}{code}
h3. Actual result
There is response error message about missing dependency but no build error message
h3. Expected result
There is built error message
was:
This Iss was spotted during review of [PR|https://github.com/kiegroup/kie-wb-common/pull/2620] for DROOLS-3829 and DROOLS-3934.
If user deploy a model with imported node, and this node miss inputs, no build error appears. However there is error if user tries to execute such model, for example via rest.
h3. Steps To Reproduce
# Deploy the attached project to kie server
# Try to execute the model as:
{code:sh}
curl -u testadmin:'admin1234;' -H "accept: application/json" -H "content-type: application/json" -X POST "http://localhost:8080/kie-server/services/rest/server/containers/dmn.imports/dmn" -d "{ \"model-namespace\" : \"https://github.com/kiegroup/drools/kie-dmn/_547C193C-0B52-45F5-877E-F74A7DD29838\", \"model-name\" : \"routes\", \"decision-name\" : [\"Traffic.Traffic\" ], \"decision-id\" : [ ], \"dmn-context\" : {\"Cars Per Hour\" : 10}}"
{code}
# You will get reuslt:
{code:json}
{
"type" : "SUCCESS",
"msg" : "OK from container 'dmn.imports'",
"result" : {
"dmn-evaluation-result" : {
"messages" : [ {
"dmn-message-severity" : "ERROR",
"message" : "Required dependency 'Cars Per Hour' not found on node 'Traffic'",
"message-type" : "REQ_NOT_FOUND",
"source-id" : "_6BA74389-CBF7-4D6A-99B1-9F494DCC323A"
} ],
"model-namespace" : "https://github.com/kiegroup/drools/kie-dmn/_547C193C-0B52-45F5-877E-F74A7DD29838",
"model-name" : "routes",
"decision-name" : "Traffic.Traffic",
"dmn-context" : {
"Cars Per Hour" : 10,
"Traffic" : { }
},
"decision-results" : {
"https://github.com/kiegroup/drools/kie-dmn/_1876D3A2-0972-4AE8-AF59-A56AD8D4FF5F#_6BA74389-CBF7-4D6A-99B1-9F494DCC323A" : {
"messages" : [ {
"dmn-message-severity" : "ERROR",
"message" : "Required dependency 'Cars Per Hour' not found on node 'Traffic'",
"message-type" : "REQ_NOT_FOUND",
"source-id" : "_6BA74389-CBF7-4D6A-99B1-9F494DCC323A"
} ],
"decision-id" : "https://github.com/kiegroup/drools/kie-dmn/_1876D3A2-0972-4AE8-AF59-A56AD8D4FF5F#_6BA74389-CBF7-4D6A-99B1-9F494DCC323A",
"decision-name" : "Traffic.Traffic",
"result" : null,
"status" : "SKIPPED"
}
}
}
}
}{code}
h3. Actual result
There is response error message about missing dependency but no build error message
h3 Expected result
There is built error message
> [DMN Editor] No Build Error about missing inputs for imported node
> ------------------------------------------------------------------
>
> Key: DROOLS-3985
> URL: https://issues.jboss.org/browse/DROOLS-3985
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.22.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: MySpace_dmn.imports.zip
>
>
> This Iss was spotted during review of [PR|https://github.com/kiegroup/kie-wb-common/pull/2620] for DROOLS-3829 and DROOLS-3934.
> If user deploy a model with imported node, and this node miss inputs, no build error appears. However there is error if user tries to execute such model, for example via rest.
> h3. Steps To Reproduce
> # Deploy the attached project to kie server
> # Try to execute the model as:
> {code:sh}
> curl -u testadmin:'admin1234;' -H "accept: application/json" -H "content-type: application/json" -X POST "http://localhost:8080/kie-server/services/rest/server/containers/dmn.imports/dmn" -d "{ \"model-namespace\" : \"https://github.com/kiegroup/drools/kie-dmn/_547C193C-0B52-45F5-877E-F74A7DD29838\", \"model-name\" : \"routes\", \"decision-name\" : [\"Traffic.Traffic\" ], \"decision-id\" : [ ], \"dmn-context\" : {\"Cars Per Hour\" : 10}}"
> {code}
> # You will get reuslt:
> {code:json}
> {
> "type" : "SUCCESS",
> "msg" : "OK from container 'dmn.imports'",
> "result" : {
> "dmn-evaluation-result" : {
> "messages" : [ {
> "dmn-message-severity" : "ERROR",
> "message" : "Required dependency 'Cars Per Hour' not found on node 'Traffic'",
> "message-type" : "REQ_NOT_FOUND",
> "source-id" : "_6BA74389-CBF7-4D6A-99B1-9F494DCC323A"
> } ],
> "model-namespace" : "https://github.com/kiegroup/drools/kie-dmn/_547C193C-0B52-45F5-877E-F74A7DD29838",
> "model-name" : "routes",
> "decision-name" : "Traffic.Traffic",
> "dmn-context" : {
> "Cars Per Hour" : 10,
> "Traffic" : { }
> },
> "decision-results" : {
> "https://github.com/kiegroup/drools/kie-dmn/_1876D3A2-0972-4AE8-AF59-A56AD8D4FF5F#_6BA74389-CBF7-4D6A-99B1-9F494DCC323A" : {
> "messages" : [ {
> "dmn-message-severity" : "ERROR",
> "message" : "Required dependency 'Cars Per Hour' not found on node 'Traffic'",
> "message-type" : "REQ_NOT_FOUND",
> "source-id" : "_6BA74389-CBF7-4D6A-99B1-9F494DCC323A"
> } ],
> "decision-id" : "https://github.com/kiegroup/drools/kie-dmn/_1876D3A2-0972-4AE8-AF59-A56AD8D4FF5F#_6BA74389-CBF7-4D6A-99B1-9F494DCC323A",
> "decision-name" : "Traffic.Traffic",
> "result" : null,
> "status" : "SKIPPED"
> }
> }
> }
> }
> }{code}
> h3. Actual result
> There is response error message about missing dependency but no build error message
> h3. Expected result
> There is built error message
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
More information about the jboss-jira
mailing list