[jboss-jira] [JBoss JIRA] (WFLY-12019) Cannot remove a undertow server resource at one time

[Brian Stansberry (Jira)]

    [ https://issues.jboss.org/browse/WFLY-12019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730693#comment-13730693 ] 

Brian Stansberry edited comment on WFLY-12019 at 5/7/19 3:32 PM:
-----------------------------------------------------------------

[~jmesnil] FYI ^^^.

[~spyrkob] That's a bug.  In this particular case maybe a good one, as the old setting didn't work properly. But in general that kind of change shouldn't happen.

[~kabirkhan] Does the management API diff thing compare operation definitions, or does it just do resources/attributes?

The problem is SimpleResourceDefinition.Parameters.setRemoveHandler() has similar logic to the old SimpleResourceDefinition constructor (figure out the restart level from the handler type), but it doesn't work because it only executes if the restartLevel is null. And it's not null; it's initialized to RESTART_ALL_SERVICES. 

https://issues.jboss.org/browse/WFCORE-4462


was (Author: brian.stansberry):
[~jmesnil] FYI ^^^.

[~spyrkob] That's a bug.  In this particular case maybe a good one, as the old setting didn't work properly. But in general that kind of change shouldn't happen.

[~kabirkhan] Does the management API diff thing compare operation definitions, or does it just do resources/attributes?

The problem is SimpleResourceDefinition.Parameters.setRemoveHandler() has similar logic to the old SimpleResourceDefinition constructor (figure out the restart level from the handler type), but it doesn't work because it only executes if the restartLevel is null. And it's not null; it's initialized to RESTART_ALL_SERVICES. 

> Cannot remove a undertow server resource at one time
> ----------------------------------------------------
>
>                 Key: WFLY-12019
>                 URL: https://issues.jboss.org/browse/WFLY-12019
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web (Undertow)
>    Affects Versions: 16.0.0.Final
>            Reporter: Bartosz Spyrko
>            Assignee: Bartosz Spyrko
>            Priority: Major
>
> Cannot remove a server attribute.
> {noformat}
> [standalone at localhost:9990 /] /subsystem=undertow/server=default-server:remove()
> {
>     "outcome" => "failed",
>     "failure-description" => "WFLYCTL0171: Removing services has lead to unsatisfied dependencies:
> Service jboss.undertow.server.default-server.default-host was depended upon by service jboss.undertow.server.default-server.default-host.filter-ref.x-powered-by-header, service jboss.undertow.server.default-server.default-host.location.
> /, service jboss.undertow.server.default-server.default-host.filter-ref.server-header",                                                                                                                                                    
>     "rolled-back" => true,
>     "response-headers" => undefined
> }
> {noformat}
> However, it can be removed executing same command again.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)