[jboss-jira] [JBoss JIRA] (WFCORE-4465) Ensure all transitive embedded are included by default

[Brian Stansberry (Jira)]

    [ https://issues.jboss.org/browse/WFCORE-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13732234#comment-13732234 ] 

Brian Stansberry commented on WFCORE-4465:
------------------------------------------

One thing I see is some of the typical client side API (OperationBuilder and OperationImpl) use wildfly-common solely for the org.wildfly.common.Assert stuff.  So that may be the issue -- Galleon is creating Operation objects and that pulls in the dep.

If that's all it is, my instinct is to stop doing that vs requiring embedded users to add the dep.

There's other use like that in the org.jboss.as.controller.client.helpers packages, in stuff  that's valid API for embedded use. All the old DeploymentPlan stuff.  (I don't mean ContextualModelControllerClient here; it's in the package but is for a quite different use case and not, IMO, an embedded one.)

> Ensure all transitive embedded are included by default
> ------------------------------------------------------
>
>                 Key: WFCORE-4465
>                 URL: https://issues.jboss.org/browse/WFCORE-4465
>             Project: WildFly Core
>          Issue Type: Task
>          Components: Embedded
>            Reporter: James Perkins
>            Assignee: James Perkins
>            Priority: Major
>
> When using the {{wildfly-embedded}} dependency it requires some additional dependencies, for example {{org.wildfly.common:wildfly-common}}, to be included. These dependencies should be examined and explicitly added as dependencies so consumers do not need to know which dependencies need to be added.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)