[jboss-jira] [JBoss JIRA] (WFCORE-4465) Ensure all transitive embedded are included by default

[Brian Stansberry (Jira)]

    [ https://issues.jboss.org/browse/WFCORE-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13732244#comment-13732244 ] 

Brian Stansberry commented on WFCORE-4465:
------------------------------------------

If we clean those Assert calls out and restore the old ControllerClientLogger.nullVar calls, I recommend leaving the Assert stuff commented out with a comment explaining not to put them back. The wildfly-common dep will still be there for the non-embedded use cases, so enterprising devs may be tempted to 'fix' the ControllerClientLogger.nullVar calls.

> Ensure all transitive embedded are included by default
> ------------------------------------------------------
>
>                 Key: WFCORE-4465
>                 URL: https://issues.jboss.org/browse/WFCORE-4465
>             Project: WildFly Core
>          Issue Type: Task
>          Components: Embedded
>            Reporter: James Perkins
>            Assignee: James Perkins
>            Priority: Major
>
> When using the {{wildfly-embedded}} dependency it requires some additional dependencies, for example {{org.wildfly.common:wildfly-common}}, to be included. These dependencies should be examined and explicitly added as dependencies so consumers do not need to know which dependencies need to be added.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)