[jboss-jira] [JBoss JIRA] (DROOLS-4735) [DMN Designer] Grid performance is dire

[Jozef Marko (Jira)]

     [ https://issues.jboss.org/browse/DROOLS-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jozef Marko updated DROOLS-4735:
--------------------------------
    Description: 
There have been reports that the performance of the DMN editor's grids does not scale. On examination performance for anything other than simple examples is pretty dire.. something is seriously wrong.

On closer inspection the following issues were found:
- Multiple {{NodeMouseDownHandler}}, {{NodeMouseMoveHandler}} and {{NodeMouseUpHandler}} are registered because multiple {{DMNGridLayer}} are (incorrectly) instantiated due to a flaw in {{GridLienzoPanel}} and {{GridLienzoScrollHandler}}.
- Calls to {{GridWidget.getHeight()}} and {{GridRow.getHeight()}} can be _very_ expensive for due to the dynamic calculation in {{ExpressionEditorGridRow}} and {{LiteralExpressionGridRow}} rows.

h2. Manual Acceptance test
Environment: wildfly14 with following memory settings: {{JAVA_OPTS="-Xms64m -Xmx1024m -XX:MetaspaceSize=96M -XX:MaxMetaspaceSize=1024m -Djava.net.preferIPv4Stack=true"}}

h3. GDT
- Merge view (/)
- Pinned mode (/)
- Change column width, save and reopen (/)
- Search the table (/)
- Scroll the table (/)
- Edit the cell (/)
- Reorder columns (/)
- Reorder rows (/)

h3. DMN decision table
- Change column width, save and reopen (x)  [^resize-column.webm]   [^resized-column-save.webm] 
- Search the grid (/)  [^search-trough-grid.webm] 
- Scroll the grid (?) scrolling seems working in reasonable time assuming number of rows, however dragging canvas is slower  [^drag-scroll.webm] 
- Reorder columns
- Reorder rows
- Adding column (?) adding column is reasonable time assuming table size, however displaying and hiding context menu is quite slow  [^add-new-column.webm] 
- Removing column (/) fine, acceptable ignoring time of showing menu reported above  [^delete-column.webm] 

  was:
There have been reports that the performance of the DMN editor's grids does not scale. On examination performance for anything other than simple examples is pretty dire.. something is seriously wrong.

On closer inspection the following issues were found:
- Multiple {{NodeMouseDownHandler}}, {{NodeMouseMoveHandler}} and {{NodeMouseUpHandler}} are registered because multiple {{DMNGridLayer}} are (incorrectly) instantiated due to a flaw in {{GridLienzoPanel}} and {{GridLienzoScrollHandler}}.
- Calls to {{GridWidget.getHeight()}} and {{GridRow.getHeight()}} can be _very_ expensive for due to the dynamic calculation in {{ExpressionEditorGridRow}} and {{LiteralExpressionGridRow}} rows.

h2. Manual Acceptance test
Environment: wildfly14 with following memory settings: {{JAVA_OPTS="-Xms64m -Xmx1024m -XX:MetaspaceSize=96M -XX:MaxMetaspaceSize=1024m -Djava.net.preferIPv4Stack=true"}}

h3. GDT
- Merge view (/)
- Pinned mode (/)
- Change column width, save and reopen (/)
- Search the table (/)
- Scroll the table (/)
- Edit the cell (/)
- Reorder columns (/)
- Reorder rows (/)

h3. DMN decision table
- Change column width, save and reopen (x)  [^resize-column.webm]   [^resized-column-save.webm] 
- Search the grid (/)  [^search-trough-grid.webm] 
- Scroll the grid (?) scrolling seems working in reasonable time assuming number of rows, however dragging canvas is slower  [^drag-scroll.webm] 
- Reorder columns
- Reorder rows
- Adding column (?) adding column is reasonable time assuming table size, however displaying and hiding context menu is quite slow  [^add-new-column.webm] 
- Removing column (/) fine, acceptable ignoring time of showing menu reported above



> [DMN Designer] Grid performance is dire
> ---------------------------------------
>
>                 Key: DROOLS-4735
>                 URL: https://issues.jboss.org/browse/DROOLS-4735
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>    Affects Versions: 7.29.0.Final
>            Reporter: Michael Anstis
>            Assignee: Michael Anstis
>            Priority: Critical
>              Labels: drools-tools
>         Attachments: aTable.dmn, add-new-column.webm, delete-column.webm, drag-scroll.webm, dtable-500-rows.dmn, resize-column.webm, resized-column-save.webm, search-trough-grid.webm
>
>
> There have been reports that the performance of the DMN editor's grids does not scale. On examination performance for anything other than simple examples is pretty dire.. something is seriously wrong.
> On closer inspection the following issues were found:
> - Multiple {{NodeMouseDownHandler}}, {{NodeMouseMoveHandler}} and {{NodeMouseUpHandler}} are registered because multiple {{DMNGridLayer}} are (incorrectly) instantiated due to a flaw in {{GridLienzoPanel}} and {{GridLienzoScrollHandler}}.
> - Calls to {{GridWidget.getHeight()}} and {{GridRow.getHeight()}} can be _very_ expensive for due to the dynamic calculation in {{ExpressionEditorGridRow}} and {{LiteralExpressionGridRow}} rows.
> h2. Manual Acceptance test
> Environment: wildfly14 with following memory settings: {{JAVA_OPTS="-Xms64m -Xmx1024m -XX:MetaspaceSize=96M -XX:MaxMetaspaceSize=1024m -Djava.net.preferIPv4Stack=true"}}
> h3. GDT
> - Merge view (/)
> - Pinned mode (/)
> - Change column width, save and reopen (/)
> - Search the table (/)
> - Scroll the table (/)
> - Edit the cell (/)
> - Reorder columns (/)
> - Reorder rows (/)
> h3. DMN decision table
> - Change column width, save and reopen (x)  [^resize-column.webm]   [^resized-column-save.webm] 
> - Search the grid (/)  [^search-trough-grid.webm] 
> - Scroll the grid (?) scrolling seems working in reasonable time assuming number of rows, however dragging canvas is slower  [^drag-scroll.webm] 
> - Reorder columns
> - Reorder rows
> - Adding column (?) adding column is reasonable time assuming table size, however displaying and hiding context menu is quite slow  [^add-new-column.webm] 
> - Removing column (/) fine, acceptable ignoring time of showing menu reported above  [^delete-column.webm] 



--
This message was sent by Atlassian Jira
(v7.13.8#713008)