[jboss-jira] [JBoss JIRA] (DROOLS-4724) [DMN Designer] Do not default to a LiteralExpression when no expression is defined

[Michael Anstis (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816562#comment-13816562 ] 

Michael Anstis commented on DROOLS-4724:
----------------------------------------

Hi [~tari_manga] I've submitted a change for the workbench (removing setting the default {{LiteralExpression}}.

However [~jomarko] discovered that when saving a {{Context}} when the {{ContextEntry}} has no expression set a NPE is thrown by {{org.kie.dmn.backend.marshalling.v1_2.xstream.ContextEntryConverter}} trying to write a {{null}} child.

My question is should the User also be able to save {{ContextEntry}} w/o an expression being explicitly set or should we default to a {{LiteralExpression}} in this scenario? If so, it would be inconsistent with both {{Decision}} nodes and {{FunctionDefinition}}s w/o an expression being explicitly set (both these scenarios pass).

I believe all three scenarios should work the same.

> [DMN Designer] Do not default to a LiteralExpression when no expression is defined
> ----------------------------------------------------------------------------------
>
>                 Key: DROOLS-4724
>                 URL: https://issues.jboss.org/browse/DROOLS-4724
>             Project: Drools
>          Issue Type: Enhancement
>          Components: DMN Editor
>            Reporter: Matteo Mortari
>            Assignee: Michael Anstis
>            Priority: Major
>              Labels: drools-tools
>         Attachments: error.log, image-2019-11-04-19-39-01-113.png, image-2019-11-04-19-40-27-201.png, save-context.webm
>
>
> Currently, the DMN Editor will default to a blank LiteralExpression on Save if the user did not provide an expression for an element.
> However Error message is reported anyway to the user:
>  !image-2019-11-04-19-39-01-113.png|thumbnail! 
> This also as the (imho undesired) side-effect that if the user was to re-open later that file, instead of a empty element, it would be a blank LiteralExpression
>  !image-2019-11-04-19-40-27-201.png|thumbnail! 
> so the current behavior is not consistent across re-open of the editor.
> Let's revert this default.
> The DMN Editor on save should +not+ default to a blank LiteralExpression if the user did not provide an expression for the element.
> Once this change is applied from the f/e side, I am happy to be involved in order to assess which of the messages reported by the Validator or the Compiler are causing issue to the WB (if any).
> Currently, the DMN Compiler will throw 1 Warning.
> Currently, the DMN Validator will throw 1 Error (I can align this to be a Warn too).
> Currently, the DMN Validator schema check is not reporting any XSD violation.
> h2. Manual acceptance test
> Try to save default / empty
> h3. Business Central
> - Decision node (/)
> - BKM node (/)
> - Cleared Function (/)
> - Context entry (x)   [^error.log]   [^save-context.webm] 
> - Invocation (/)
> h3. Kogito
> - Decision node (/)
> - BKM node (/)
> - Cleared Function (/)
> - Context entry (/)
> - Invocation (/)



--
This message was sent by Atlassian Jira
(v7.13.8#713008)