[jboss-jira] [JBoss JIRA] (DROOLS-4791) [DMN Designer] Not able to edit by double click after scroll

[Michael Anstis (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816627#comment-13816627 ] 

Michael Anstis edited comment on DROOLS-4791 at 11/22/19 7:13 AM:
------------------------------------------------------------------

The issue is that https://github.com/kiegroup/appformer/commit/ffadd2baab7067ebac737db32e633a4dd3d84452 added a {{MouseDownHandler}} on the {{FocusPanel}} that erm, sets the focus to the {{FocusPanel}} in response to a mouse down event. This causes the "in cell" editor to receive a _blur_ event and destroy the "in cell" editor. There is no need to add an explicit {{MouseDownHandler}} to set the focus on a focus panel as it's a *focus* panel and gets the focus on click anyway!

I tested the large file attached to this JIRA with {{kie-wb-common-dmn-webapp-kogito-testing}} and {{kie-wb-distributions}}. Both work well now. I have also tested that the Guided Decision Table Editor and Scenario Simulation Editor are unaffected by this change and that keyboard navigation is unaffected by the removal of the explicit focus handling.


was (Author: manstis):
The issue is that https://github.com/kiegroup/appformer/commit/ffadd2baab7067ebac737db32e633a4dd3d84452 added a `MouseDownHandler` on the `FocusPanel` that erm, sets the focus to the `FocusPanel` in response to a mouse down event. This causes the "in cell" editor to receive a _blur_ event and destroy the "in cell" editor. There is no need to add an explicit `MouseDownHandler` to set the focus on a focus panel as it's a *focus* panel and gets the focus on click anyway!

I tested the large file attached to this JIRA with `kie-wb-common-dmn-webapp-kogito-testing` and `kie-wb-distributions`. Both work well now. I have also tested that the Guided Decision Table Editor and Scenario Simulation Editor are unaffected by this change and that keyboard navigation is unaffected by the removal of the explicit focus handling.

> [DMN Designer] Not able to edit by double click after scroll
> ------------------------------------------------------------
>
>                 Key: DROOLS-4791
>                 URL: https://issues.jboss.org/browse/DROOLS-4791
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>    Affects Versions: 7.31.0.Final
>            Reporter: Jozef Marko
>            Assignee: Michael Anstis
>            Priority: Critical
>              Labels: drools-tools
>         Attachments: aTable.dmn, edit-cell.webm
>
>
> User is not able to invoke cell edito mode if he scrolled the dmn grid before.
> *Acceptance criteria*
> *_DMN_*
> - Import the attached file.
> - Follow general steps below.
> *_Guided Decision Table_*
> - Create/open existing asset.
> - Follow general steps below.
> *_Scenario Simulation_*
> - Create/open existing asset.
> - Follow general steps below.
> *_General steps_*
> (?) Double-click in cell to edit.
> (?) Press {{<Tab>}} keyboard operation should work.
> (?) Double-click in cell to edit.
> (?) Press {{<Escape>}} keyboard operation should work.
> (?) Click _elsewhere _ e.g. browser address bar.
> (?) Keyboard operation should not work (editor does not have focus)
> (?) Click on grid.
> (?) Keyboard operation should work.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)