[jboss-jira] [JBoss JIRA] (DROOLS-4807) [DMN Designer] Do not group V&V messages by UUID

[Michael Anstis (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818045#comment-13818045 ] 

Michael Anstis commented on DROOLS-4807:
----------------------------------------

[~tdolphine] [~kgaevski] [~roger.martinez] Can you please comment on this.

https://github.com/kiegroup/kie-wb-common/pull/2661/files#diff-6d2350428776ae38ae6c02acadaa0033R64 added grouping of {{DomainViolation}} by (graph) {{element id}}. This seems to have the opposite effect to that requested by https://issues.jboss.org/browse/JBPM-7436 that seemed to request messages should be split. Can you confirm BPMN's use of [ProjectValidationServiceImpl|https://github.com/kiegroup/kie-wb-common/blob/master/kie-wb-common-stunner/kie-wb-common-stunner-extensions/kie-wb-common-stunner-project/kie-wb-common-stunner-project-backend/src/main/java/org/kie/workbench/common/stunner/project/backend/service/ProjectValidationServiceImpl.java] is working as expected? 

If BPMN is working as expected then I'll need to work out a way to allow DMN's {{DomainValidator}}'s {{DomainViolation}} objects not to be grouped whilst preserving the grouping behaviour applied to BPMN's {{DomainValidator}} {{DomainViolation}} messages. 

> [DMN Designer] Do not group V&V messages by UUID
> ------------------------------------------------
>
>                 Key: DROOLS-4807
>                 URL: https://issues.jboss.org/browse/DROOLS-4807
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>    Affects Versions: 7.30.0.Final
>            Reporter: Michael Anstis
>            Assignee: Michael Anstis
>            Priority: Major
>              Labels: drools-tools
>         Attachments: V&V.png
>
>
> The V&V results are grouped by UUID. See attached screen-shot.
> These items are reported individually by {{kie-dmn-validation}} but grouped by {{org.kie.workbench.common.dmn.showcase.backend.validation.ValidationServiceImpl}} in the _standalone_ webapp however I fear Stunner's generic {{ValidationService}} does the same in Business Central and hence reporting DMN V&V per-line may be more troublesum.
> See [here|https://github.com/kiegroup/kie-wb-common/blob/master/kie-wb-common-dmn/kie-wb-common-dmn-webapp-standalone/src/main/java/org/kie/workbench/common/dmn/showcase/backend/validation/ValidationServiceImpl.java#L56] that should more correctly be:-
> {code}
>     @Override
>     public Collection<DiagramElementViolation<RuleViolation>> validate(Diagram diagram) {
>         return domainViolations(diagram).stream()
>                 .filter(v -> Objects.nonNull(v.getUUID()))
>                 .filter(v -> !"null".equals(v.getUUID()))
>                 .map(v -> new ElementViolationImpl.Builder().setUuid(v.getUUID()).setDomainViolations(Collections.singletonList(v)).build())
>                 .collect(Collectors.toList());
>     }
> {code}



--
This message was sent by Atlassian Jira
(v7.13.8#713008)