[jboss-jira] [JBoss JIRA] (WFLY-12348) JPA statistics fix (WFLY-10964) should be applied to JPA 2.1 as well

[Scott Marlow (Jira)]

    [ https://issues.jboss.org/browse/WFLY-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792458#comment-13792458 ] 

Scott Marlow commented on WFLY-12348:
-------------------------------------

The [https://github.com/hibernate/hibernate-orm/tree/master/hibernate-jipijapa/src/main/java/org/jboss/as/jpa/hibernate5/management] is a fork, I wanted to move all of the Hibernate integration code there, but I found out after that being discussed, that we needed to keep that code in WildFly, for addressing clustering issues.  So, the Hibernate copy of that code, is a mostly for the Hibernate testsuite but could possibly be used by some users.  The sources in Hibernate use tabs instead of spaces and have other cosmetic differences.  I can mention some steps that you could take to sync changes made in WildFly with the forked code in the Hibernate project, if your interested in creating a Hibernate ORM pull request for that.

Could you please verify that [https://github.com/scottmarlow/wildfly/tree/WFLY-12348_jpa2.1] contains the changes that you had in mind and work for you?  I'll create a pull request for the change after I hear back from you.

Thanks for reporting this!

Scott


> JPA statistics fix (WFLY-10964) should be applied to JPA 2.1 as well
> --------------------------------------------------------------------
>
>                 Key: WFLY-12348
>                 URL: https://issues.jboss.org/browse/WFLY-12348
>             Project: WildFly
>          Issue Type: Bug
>          Components: JPA / Hibernate
>    Affects Versions: 17.0.1.Final
>            Reporter: Jippe Holwerda
>            Assignee: Scott Marlow
>            Priority: Major
>
> Microprofile Metrics in Wildfly 17.0.1 in combination with JPA 2.1 is currently broken. The fix done in WFLY-10964 (https://github.com/wildfly/wildfly/commit/9dac9810796469ab45cb2b6e0fde926b9d193561) should be applied to the JPA 2.1 version (wildfly/jpa/hibernate5) as well.
> Also, the same faulty code is present in Hibernate: https://github.com/hibernate/hibernate-orm/tree/master/hibernate-jipijapa/src/main/java/org/jboss/as/jpa/hibernate5/management
> Not sure why it is in there as well, but it probably should be fixed or removed.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)