[jboss-jira] [JBoss JIRA] (WFLY-12348) JPA statistics fix (WFLY-10964) should be applied to JPA 2.1 as well

[Jippe Holwerda (Jira)]

    [ https://issues.jboss.org/browse/WFLY-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795982#comment-13795982 ] 

Jippe Holwerda commented on WFLY-12348:
---------------------------------------

The fork in https://github.com/scottmarlow/wildfly/tree/WFLY-12348_jpa2.1 does indeed contain the correct changes. So if you could create a pull request for that, that would be great!

Regarding the duplicate code, I've also created an issue in the Hibernate Jira: https://hibernate.atlassian.net/browse/HHH-13533.
I'm not sure if syncing the code is the best strategy, as it will only be a matter of time before the code will be out-of-sync again. I would argue for getting rid of the duplication, although I can imagine that it would be more work (in the short term).

> JPA statistics fix (WFLY-10964) should be applied to JPA 2.1 as well
> --------------------------------------------------------------------
>
>                 Key: WFLY-12348
>                 URL: https://issues.jboss.org/browse/WFLY-12348
>             Project: WildFly
>          Issue Type: Bug
>          Components: JPA / Hibernate
>    Affects Versions: 17.0.1.Final
>            Reporter: Jippe Holwerda
>            Assignee: Scott Marlow
>            Priority: Major
>
> Microprofile Metrics in Wildfly 17.0.1 in combination with JPA 2.1 is currently broken. The fix done in WFLY-10964 (https://github.com/wildfly/wildfly/commit/9dac9810796469ab45cb2b6e0fde926b9d193561) should be applied to the JPA 2.1 version (wildfly/jpa/hibernate5) as well.
> Also, the same faulty code is present in Hibernate: https://github.com/hibernate/hibernate-orm/tree/master/hibernate-jipijapa/src/main/java/org/jboss/as/jpa/hibernate5/management
> Not sure why it is in there as well, but it probably should be fixed or removed.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)