[jboss-jira] [JBoss JIRA] (DROOLS-2845) Extend the existing verifier to support DMN tables

[Toni Rikkola (Jira)]

     [ https://issues.jboss.org/browse/DROOLS-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Toni Rikkola updated DROOLS-2845:
---------------------------------
    Description: 
h1. Goal
Reuse the V&V created for Guided Decision Tables on the DMN tables. 
h1. Workload divided to steps
I propose the work goes in the following steps. After each step I should be able to merge into master.

Steps:
# Move Verifier core to kie-wb-common
# Move V&V reporting UI to kie-wb-common
# Make the web worker connector reusable for different V&V types
# -Make a servlet module for DMN that allows the download of the Web Worker.-
# Create an adapter for DMN tables
# Add support for ranges ( these are given in DMN so no need to use JSR303 )
# Duplicate i18n of the V&V for DMN or unify the reports so that the terms make sense


  was:
h1. Goal
Reuse the V&V created for Guided Decision Tables on the DMN tables. 
h1. Workload divided to steps
I propose the work goes in the following steps. After each step I should be able to merge into master.

Steps:
# Move Verifier core to kie-wb-common
# Move V&V reporting UI to kie-wb-common
# Make the web worker connector reusable for different V&V types
# Make a servlet module for DMN that allows the download of the Web Worker.
# Create an adapter for DMN tables
# Add support for ranges ( these are given in DMN so no need to use JSR303 )
# Duplicate i18n of the V&V for DMN or unify the reports so that the terms make sense

h1. Time and risks
h2. #1, #2, #3, #4 and #7 moving, copying code or doing refactoring
Most of the work items are just about moving, copying code or doing refactoring. These are easy to estimate and I think they are doable in one sprint along with everything else I do. Already started few of these so it is easier for me to estimate how long they take. 
h2. 5. Create an adapter for DMN tables 
Adapters job is to take the model ( DMN or dtable ) and tear it down into smaller bits that the Verifier actually inspects. The core Verifier basically only sees rules or rows as collections of conditions and actions. This is why I feel once the adapter is done, the verifier will automatically work for DMN tables. This adapter also keeps track of the cell to action/condition connections.
This area is where most of the work is that is hard to estimate, since there is some unknowns here. In theory DMN adapter is a lot easier to do than the DTable adapter was. Due to the unknown I will have to say 3 weeks.
h2. 6. Add support for ranges 
Mario helped to get the range checks in order. The V&V now works with unlimited ranges, but adding known range limitation is in a way just about adding in the data of a mock rule that checks for the area that is outside of the range. I’ll play it safe here and say one week, but at the moment this feels really easy.
h1. Just to make it clear
This work only targets the DMN table in the similar format that it is in the Guided Decision Table. So it does not cover a Verification of the entire DMN diagram that can have several tables that possibly complete each other. We have the same situation if we have multiple DRL Tables in a ksession. 




> Extend the existing verifier to support DMN tables
> --------------------------------------------------
>
>                 Key: DROOLS-2845
>                 URL: https://issues.jboss.org/browse/DROOLS-2845
>             Project: Drools
>          Issue Type: Epic
>          Components: DMN Editor, verifier
>            Reporter: Toni Rikkola
>            Assignee: Toni Rikkola
>            Priority: Optional
>              Labels: UX, drools-tools, verifier
>
> h1. Goal
> Reuse the V&V created for Guided Decision Tables on the DMN tables. 
> h1. Workload divided to steps
> I propose the work goes in the following steps. After each step I should be able to merge into master.
> Steps:
> # Move Verifier core to kie-wb-common
> # Move V&V reporting UI to kie-wb-common
> # Make the web worker connector reusable for different V&V types
> # -Make a servlet module for DMN that allows the download of the Web Worker.-
> # Create an adapter for DMN tables
> # Add support for ranges ( these are given in DMN so no need to use JSR303 )
> # Duplicate i18n of the V&V for DMN or unify the reports so that the terms make sense



--
This message was sent by Atlassian Jira
(v7.13.5#713005)