[jboss-jira] [JBoss JIRA] (WFWIP-184) Can't specify arbitrary Persistent Volume Claim Name

[Martin Choma (Jira)]

    [ https://issues.jboss.org/browse/WFWIP-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782007#comment-13782007 ] 

Martin Choma commented on WFWIP-184:
------------------------------------

I admit there is not strong UseCase for this. I can think just artificiall as reusing existing PVC, complying to company naming convention. I could want to reuse PVC because of migrating from legacy applications to operator approach. And reattach operator pods to the data saved by the previous instances.

I just hit this because I was expecting name is required.

If not we should inform somehow (in documentation, CRD?) user he doesn't have to (must not) specify name. Best would be to validate somehow in time of saving WildFly CR and return to user meaningful exception. 
Based on current exception I wouldn't find out what is going on without assistance of my coleague, who hit this before me.

Is validation of user input possible in Operator? Does Operator framework provide any support? Is it possible to define some basic validations in CRD?

> Can't specify arbitrary Persistent Volume Claim Name
> ----------------------------------------------------
>
>                 Key: WFWIP-184
>                 URL: https://issues.jboss.org/browse/WFWIP-184
>             Project: WildFly WIP
>          Issue Type: Bug
>          Components: OpenShift
>            Reporter: Martin Choma
>            Assignee: Jeff Mesnil
>            Priority: Major
>
> I cant create PVC with arbitrary name. It must be empty [3] or "<CR name>-volume" [2]
> When I specify PVC name I get error like
> {code}
> create Pod simple-jaxrs-eap72-0 in StatefulSet simple-jaxrs-eap72 failed error: Pod "simple-jaxrs-eap72-0" is invalid: spec.containers[0].volumeMounts[0].name: Not found: "simple-jaxrs-eap72-volume"
> {code}
> Is there any reason to not permit arbitrary PVC name?
> [1] https://github.com/wildfly/wildfly-operator/blob/master/pkg/controller/wildflyserver/wildflyserver_controller.go#L401
> [2] https://github.com/wildfly/wildfly-operator/blob/master/pkg/controller/wildflyserver/wildflyserver_controller.go#L309
> [3] https://github.com/wildfly/wildfly-operator/blob/master/pkg/controller/wildflyserver/wildflyserver_controller.go#L348



--
This message was sent by Atlassian Jira
(v7.13.5#713005)