[jboss-jira] [JBoss JIRA] (DROOLS-4557) Missing semantic validation of DMN file

[Gabriele Cardosi (Jira)]

     [ https://issues.jboss.org/browse/DROOLS-4557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabriele Cardosi updated DROOLS-4557:
-------------------------------------
    Description: 
If a semantically wrong file is parsed by the marshaller, exception may be thrown but they are not meaningfull.
As example, the attached file raise a NPE at _DMNMarshallerStandalone_ because  at this line


{code:java}
Node sourceNode = Optional.ofNullable(elems.get(sourceId)).map(Entry::getValue).orElse(textAnnotations.get(sourceId));
{code}


_elements_ is empty.

So, even if the file is syntactically correct, it is semantically wrong; but this semantic check seems not implemented.

         `

  was:
If a semantically wrong file is parsed by the marshaller, exception may be thrown but they are not meaningfull.
As example, the attached file raise a NPE at `DMNMarshallerStandalone` because  at this line `   Node sourceNode = Optional.ofNullable(elems.get(sourceId)).map(Entry::getValue).orElse(textAnnotations.get(sourceId));` elemens is empty.
So, even if the file is syntactically correct, it is semantically wrong; but this semantic check seems not implemented.

         `



> Missing semantic validation of DMN file
> ---------------------------------------
>
>                 Key: DROOLS-4557
>                 URL: https://issues.jboss.org/browse/DROOLS-4557
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>            Reporter: Gabriele Cardosi
>            Assignee: Michael Anstis
>            Priority: Major
>         Attachments: E3083400-878D-49DB-8E72-105FDB6BAF44.dmn
>
>
> If a semantically wrong file is parsed by the marshaller, exception may be thrown but they are not meaningfull.
> As example, the attached file raise a NPE at _DMNMarshallerStandalone_ because  at this line
> {code:java}
> Node sourceNode = Optional.ofNullable(elems.get(sourceId)).map(Entry::getValue).orElse(textAnnotations.get(sourceId));
> {code}
> _elements_ is empty.
> So, even if the file is syntactically correct, it is semantically wrong; but this semantic check seems not implemented.
>          `



--
This message was sent by Atlassian Jira
(v7.13.8#713008)