[jboss-jira] [JBoss JIRA] (WFLY-13341) Substitution of environment / system properties for microprofile-opentracing-smallrye extension

[Brian Stansberry (Jira)]

     [ https://issues.redhat.com/browse/WFLY-13341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Stansberry updated WFLY-13341:
------------------------------------
    Issue Type: Bug  (was: Feature Request)


I don't see this as a feature request. Not supporting an expression on an attribute whose value isn't a capability reference, class name or module name should be regarded as a bug unless there is a strong case why it has to be that way. And if there was such a case, eliminating that case would be an Enhancement, not a Feature. The fact that attributes support expressions is a WildFly feature in place since JBoss AS 7.0. Making that existing feature work isn't a new feature, i.e. something that requires the analysis test planning and documentation that we do for features.

> Substitution of environment / system properties for microprofile-opentracing-smallrye extension
> -----------------------------------------------------------------------------------------------
>
>                 Key: WFLY-13341
>                 URL: https://issues.redhat.com/browse/WFLY-13341
>             Project: WildFly
>          Issue Type: Bug
>          Components: MP OpenTracing
>    Affects Versions: 19.0.0.Final
>            Reporter: Yeray Borges Santana
>            Assignee: Emmanuel Hugonnet
>            Priority: Major
>
> I would like to able to configure the microprofile-opentracing-smallrye extension in wildfly 19 with substituted variables (environment or system).
> When I try this it seems the values are not resolved, for example
> {code:xml}
> <subsystem xmlns="urn:wildfly:microprofile-opentracing-smallrye:2.0" default-tracer="jaeger">
>     <jaeger-tracer name="jaeger">
>         <tags>
>             <property name="env" value="${env.ENV}"/>
>             <property name="user" value="joe"/>
>         </tags>
>         <sampler-configuration sampler-type="ratelimiting" sampler-param="1.0"/>
>         <sender-configuration sender-endpoint="http://${JAEGER_AGENT_HOST}:14268/api/traces"/>
>     </jaeger-tracer>
> </subsystem>
> {code}
> results in:
> {noformat}
> 2020-03-29 15:17:49,448 ERROR [jaeger.RemoteReporter-QueueProcessor] [] [] [] [] [] (io.jaegertracing.internal.reporters
> .RemoteReporter) QueueProcessor error:: java.lang.RuntimeException: java.net.URISyntaxException: Illegal character in au
> thority at index 7: http://${jaeger_agent_host}:14268/
>         at com.squareup.okhttp3//okhttp3.HttpUrl.uri(HttpUrl.java:385)
>         at com.squareup.okhttp3//okhttp3.internal.connection.RouteSelector.resetNextProxy(RouteSelector.java:129)
>         at com.squareup.okhttp3//okhttp3.internal.connection.RouteSelector.<init>(RouteSelector.java:63)
>         at com.squareup.okhttp3//okhttp3.internal.connection.StreamAllocation.<init>(StreamAllocation.java:101)
> {noformat}



--
This message was sent by Atlassian Jira
(v7.13.8#713008)