[jboss-jira] [JBoss JIRA] (WFLY-1415) Move away from expensive enum switch

[Darran Lofthouse (Jira)]

    [ https://issues.redhat.com/browse/WFLY-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026718#comment-14026718 ] 

Darran Lofthouse commented on WFLY-1415:
----------------------------------------

I don't think my comments stand as much about the topic branches but I think the general pattern for parsing has changed a lot over the last five years so a lot of the newer code shouldn't be as affected by this.

> Move away from expensive enum switch
> ------------------------------------
>
>                 Key: WFLY-1415
>                 URL: https://issues.redhat.com/browse/WFLY-1415
>             Project: WildFly
>          Issue Type: Task
>            Reporter: David Lloyd
>            Priority: Minor
>              Labels: janitor
>
> We use enums and enum switch extensively.  These constructs generate many, many additional classes and bloat the code base unnecessarily.
> All cases where we are using enum-based switches for our XML parsers should be converted to use Java 7 String switch instead.  The enum values shall be replaced with String constant fields, all enum switches converted to String switches, and all enum types removed from these classes.  The net result should be a reduction by dozens if not hundreds of .class files, and possibly a measurable performance boost as well.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)