[jboss-jira] [JBoss JIRA] (DROOLS-5229) DMNValidate mojo fails XMLSchema validation with included models

[Matteo Mortari (Jira)]

    [ https://issues.redhat.com/browse/DROOLS-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027629#comment-14027629 ] 

Matteo Mortari commented on DROOLS-5229:
----------------------------------------

Hi [~tracyhires] thanks for reporting, the editor generated ID in the file is indeed not XML-valid, will be taken care of.

I just need however to highlight something you mentioned, which is not actually correct:
bq. though disabling DMNValidation for an XML Schema validation also prevents finding FEEL parser errors

Most FEEL parser error are actually detected during DMN "compilation" phase. So disabling DMNValidation, will disable only XSD schema check and static analysis (before compilation). 
Ref.: https://docs.jboss.org/drools/release/7.35.0.Final/drools-docs/html_single/index.html#kie-dmn-validation-in-maven-plugin
Consequently, using the Maven pom.xml settings you suggest does indeed circumvent the XSD schema validation checks, but it will still perform FEEL parser checks, as those happens during DMN model compilation.

> DMNValidate mojo fails XMLSchema validation with included models
> ----------------------------------------------------------------
>
>                 Key: DROOLS-5229
>                 URL: https://issues.redhat.com/browse/DROOLS-5229
>             Project: Drools
>          Issue Type: Bug
>    Affects Versions: 7.34.0.Final
>            Reporter: Tracy Hires
>            Assignee: Guilherme Gomes
>            Priority: Minor
>         Attachments: ValidateDMN Mojo Failure.png, xml_validation_error.zip
>
>
> The attached DMN decision project was built using Business Central 7.34.0.Final.  In this project, the dmn model `Math Functions.dmn` invokes business knowledge model `Quotient` from dmn model `Divide.dmn`. Invoking the ValidateDMN mojo (enabled by default) from the kie-maven-plugin fails XML Validation. One can get past this error by disabling DMNValidation with the following configuration in the pom (though disabling DMNValidation for an XML Schema validation also prevents finding FEEL parser errors):
> ```
>   <build>
>     <plugins>
>       <plugin>
>         <groupId>org.kie</groupId>
>         <artifactId>kie-maven-plugin</artifactId>
>         <version>7.34.0.Final</version>
>         <extensions>true</extensions>
>         <!-- Can get past xml validation error by disabling the ValidateDMN Mojo -->
>         <configuration>
>           <validateDMN>disabled</validateDMN>
>         </configuration>
>       </plugin>
>     </plugins>
>   </build>
> ```
> When one combines the two dmn models into a single model, the XML Validation succeeds (this example is not supplied, but is trivial to re-build).



--
This message was sent by Atlassian Jira
(v7.13.8#713008)