[jboss-jira] [JBoss JIRA] (WFLY-13221) Remove package-schema cruft from wildfly-feature-pack-build.xml files
Brian Stansberry (Jira)
issues at jboss.org
Mon Apr 13 15:16:45 EDT 2020
[ https://issues.redhat.com/browse/WFLY-13221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033285#comment-14033285 ]
Brian Stansberry commented on WFLY-13221:
-----------------------------------------
[~yersan] I don't recall the history behind this and may not have been involved. But I suspect that before the legacy feature packs were introduced we had hand coded the schemas that got included, which meant a manual decision-making process. And then the legacy feature packs encoded the same result.
We ship a lot of libraries some of which may include schemas that are irrelevant to WildFly. It's a valid discussion whether to filter them out. Not super urgent though. :). But a discussion would need to have some data, i.e. what would be included that isn't already.
> Remove package-schema cruft from wildfly-feature-pack-build.xml files
> ---------------------------------------------------------------------
>
> Key: WFLY-13221
> URL: https://issues.redhat.com/browse/WFLY-13221
> Project: WildFly
> Issue Type: Task
> Components: Build System
> Reporter: Brian Stansberry
> Assignee: Yeray Borges Santana
> Priority: Minor
>
> The various wildfly-feature-pack-build.xml files include 'package-schemas' elements. AIUI the children of those elements only need to refer to maven groupId for which that specific feature pack provides artifacts with schemas. It does not need to include groupIds for artifacts from other f-ps that the f-p depends on. The WF galleon plugin itself combines those.
> So the task is
> 1) to clean out cruft, i.e. elements that are related to artifacts from other feature packs. Helps clarify the expected use of these files.
> 2) Perhaps in the verifier tests for servlet-dist, ee-dist, dist add verification of the presence of 1 schema from each relevant maven groupId. Guard against schemas suddenly not getting picked up.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
More information about the jboss-jira
mailing list