[jboss-jira] [JBoss JIRA] (WFLY-13314) Metrics smallrye contains duplicated help lines

[Jeff Mesnil (Jira)]

    [ https://issues.redhat.com/browse/WFLY-13314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048377#comment-14048377 ] 

Jeff Mesnil commented on WFLY-13314:
------------------------------------

This has been fixed in the latest smallrye-metrics we integrated in WildFly 19 (smallrye-metrics:2.3.2).

When I query the metrics on a WildFly 19.0.0.Final server, I have distinct HELP lines for the 2 metrics:

{code}
curl http://:9990/metrics | grep base_gc  | grep HELP
# HELP base_gc_time_total Displays the approximate accumulated collection elapsed time in milliseconds. This attribute displays -1 if the collection elapsed time is undefined for this collector. The Java virtual machine implementation may use a high resolution timer to measure the elapsed time. This attribute may display the same value even if the collection count has been incremented if the collection elapsed time is very short.
# HELP base_gc_total Displays the total number of collections that have occurred. This attribute lists -1 if the collection count is undefined for this collector.
{code}


> Metrics smallrye contains duplicated help lines
> -----------------------------------------------
>
>                 Key: WFLY-13314
>                 URL: https://issues.redhat.com/browse/WFLY-13314
>             Project: WildFly
>          Issue Type: Bug
>          Components: MP Metrics
>    Affects Versions: 18.0.1.Final
>            Reporter: Matthias Depuydt
>            Assignee: Jeff Mesnil
>            Priority: Critical
>             Fix For: 19.0.0.Final
>
>
> The metrics endpoint on which the wildfly microprofile-metrics-smallrye:2.0 subsystem exposes all metrics can't be scraped with prometheus.
> Both the base_gc_time_total & base_gc_total metrics have their help line duplicated which causes prometheus to throw the following error:
> Could not build time series for component wildfly: text format parsing error in line 34: second HELP line for metric name "base_gc_total"
> I have confirmed this is the case for wildfly 18.0.1



--
This message was sent by Atlassian Jira
(v7.13.8#713008)