[jboss-jira] [JBoss JIRA] (WFLY-13405) Update CommonDeploymentService in release.

[Brian Stansberry (Jira)]

    [ https://issues.redhat.com/browse/WFLY-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064024#comment-14064024 ] 

Brian Stansberry commented on WFLY-13405:
-----------------------------------------

Thanks [~algolua7] for the report.

I'm not sure what fix wasn't released yet as nothing has been done on this AFAIK.

The problem is clear enough. The only thing that's confusing to me is why this isn't reported constantly as CommonDeploymentService has been the same since 2015 and usually gets installed.

[~jamezp] is this call stack, running through Slf4jLocationAwareLogger, what you'd expect for container code?

{code}
Caused by: java.util.MissingFormatArgumentException: Format specifier '%s'
	at java.base/java.util.Formatter.format(Formatter.java:2580) ~[na:na]
	at java.base/java.util.Formatter.format(Formatter.java:2517) ~[na:na]
	at java.base/java.lang.String.format(String.java:2747) ~[na:na]
	at org.jboss.logging//org.jboss.logging.Slf4jLocationAwareLogger.doLogf(Slf4jLocationAwareLogger.java:81) ~[na:na]
	at org.jboss.logging//org.jboss.logging.Logger.logf(Logger.java:2445) ~[na:na]
	at org.jboss.logging//org.jboss.logging.DelegatingBasicLogger.debugf(DelegatingBasicLogger.java:344) ~[na:na]
	at org.jboss.as.connector//org.jboss.as.connector.subsystems.datasources.CommonDeploymentService.start(CommonDeploymentService.java:59) ~[na:na]
	at org.jboss.msc//org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:2032) ~[jboss-msc-1.2.7.SP1-redhat-1.jar!/:1.2.7.SP1-redhat-1]
	at org.jboss.msc//org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1955) ~[jboss-msc-1.2.7.SP1-redhat-1.jar!/:1.2.7.SP1-redhat-1]
{code}

The DelegatingBasicLogger there is org.jboss.as.connector.logging.ConnectorLogger.ROOT_LOGGER.

The JBossLogManagerLogger.doLogf implementation is quite different from Slf4jLocationAwareLogger, which makes me wonder if Slf4jLocationAwareLogger being in the mix is unusual and the reason this service start failure is happening. Following the JBossLogManagerLogger rabbit hole I get eventually to StreamHandler.publish(LogRecord record) which passes failures off to a j.u.l.ErrorManager instead of propagating them.

This doesn't really matter to the specific fix here; it's just made me wonder if there's something else going on here that would be good to understand.

> Update CommonDeploymentService in release.
> ------------------------------------------
>
>                 Key: WFLY-13405
>                 URL: https://issues.redhat.com/browse/WFLY-13405
>             Project: WildFly
>          Issue Type: Bug
>    Affects Versions: 19.0.0.Final
>            Reporter: Alexander Golovko
>            Assignee: Brian Stansberry
>            Priority: Major
>         Attachments: debug.log
>
>
> Current calls of ROOT_LOGGER.debugf("Started/Stopped CommonDeployment %s", new Object[0]); are errors. They raise MissingFormatArgumentException exception since new Object[0] is an empty array and is not compatible with %s in format argument.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)