[jboss-jira] [JBoss JIRA] (WFLY-13734) JPA subsystem should fail deployment if ValidationMode.CALLBACK is configured but the BV capability is not present

[Yeray Borges Santana (Jira)]

    [ https://issues.redhat.com/browse/WFLY-13734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356058#comment-14356058 ] 

Yeray Borges Santana commented on WFLY-13734:
---------------------------------------------

Hi [~brian.stansberry], I see your point about we already have BV, indeed as an optional dependency, for {{cloud-server}} and {{jaxrs-server}} base layer, so adding it as an optional dep for {{jpa}} / {{jpa-distributed}} is harmless for these two base layers.

So, if I understood well, we could need to add BV as optional dep for {{jpa}} / {{jpa-distributed}}  to be able to use ValidationMode.NONE with, in addition within {{cloud-server}} and {{jaxrs-server}},  with `datasources-web-server` layer and ValidationMode.CALLBACK with all of them excluding the BV optional dependency, right?

I'm not familiar with BV, is CDI a requirement to get it working? If so, CDI already incorporates BV. That could mean we don't require to add it to {{jpa}} / {{jpa-distributed}} 

> JPA subsystem should fail deployment if ValidationMode.CALLBACK is configured but the BV capability is not present
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: WFLY-13734
>                 URL: https://issues.redhat.com/browse/WFLY-13734
>             Project: WildFly
>          Issue Type: Bug
>          Components: JPA / Hibernate
>            Reporter: Brian Stansberry
>            Assignee: Scott Marlow
>            Priority: Major
>             Fix For: No Release
>
>
> This is a follow-on to https://github.com/wildfly/wildfly/pull/13444 / WFLY-13726.  That fix is about applying logic consistently in both places where PersistenceUnitServiceHandler integrates with BV. But I suspect the existing handling isn't correct in the case where ValidationMode.CALLBACK is configured. The javadoc for that enum value says "The persistence provider must perform the lifecycle event validation.  It is an error if there is no Bean Validation provider present in the environment." But I think our handling is ignoring that if the BV capability is not present.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)